Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============6384479696784336137=="
MIME-Version: 1.0
Subject: Re: Review Request 17888: Dispatcher corrections,
 refactoring and tests. Corrects problems from previous attempt
From: "Antonio Fornie" <antonio.fornie@gmail.com>
To: "daan Hoogland" <daan.hoogland@gmail.com>,
 "Hugo Trippaers" <htrippaers@schubergphilis.com>,
 "Alena Prokharchyk" <alena.prokharchyk@citrix.com>
Cc: "Antonio Fornie" <antonio.fornie@gmail.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Fri, 07 Mar 2014 15:38:46 -0000
Message-ID: <20140307153846.30871.36981@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Antonio Fornie" <noreply@reviews.apache.org>
References: <20140306163651.1691.20728@reviews.apache.org>
In-Reply-To: <20140306163651.1691.20728@reviews.apache.org>
Reply-To: "Antonio Fornie" <antonio.fornie@gmail.com>

--===============6384479696784336137==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
-----------------------------------------------------------

(Updated March 7, 2014, 3:38 p.m.)


Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo Trippaers.


Changes
-------

Fix conflicts with last master


Repository: cloudstack-git


Description
-------

Dispatcher corrections, refactoring and tests. Corrects problems from previous attempts that were reverted by Alena. Most of the changes are the same, but this one is not creating conflicts of Map types for Aync Commands or for parameters as Lists or Maps.


Diffs (updated)
-----

  api/src/org/apache/cloudstack/api/ApiConstants.java 14df653 
  api/src/org/apache/cloudstack/api/BaseCmd.java e869ddf 
  api/src/org/apache/cloudstack/api/BaseListCmd.java c1a4b4c 
  api/test/org/apache/cloudstack/api/BaseCmdTest.java PRE-CREATION 
  server/resources/META-INF/cloudstack/core/spring-server-core-misc-context.xml fd2f5fb 
  server/src/com/cloud/api/ApiDispatcher.java 5bdefe7 
  server/src/com/cloud/api/ApiServer.java 7e29324 
  server/src/com/cloud/api/ApiServlet.java 46f7eba 
  server/src/com/cloud/api/dispatch/CommandCreationWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchChain.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchChainFactory.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchTask.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamProcessWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamUnpackWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/SpecificCmdValidationWorker.java PRE-CREATION 
  server/src/com/cloud/network/as/AutoScaleManagerImpl.java 208b4a4 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 37171f5 
  server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java a85c052 
  server/test/com/cloud/api/ApiDispatcherTest.java 7314a57 
  server/test/com/cloud/api/dispatch/CommandCreationWorkerTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/DispatchChainFactoryTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/ParamProcessWorkerTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/ParamSemanticValidationWorkerTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/17888/diff/


Testing
-------

Full build and test plus manually testing many features. Also including CreateTagsCommand that failed in previous commit.

All unit and integration tests.

Test CS Web UI with the browser going through several use cases.

Also use the CS API by sending HTTP requests generated manually including requests for Async Commands with Map parameters and during these tests apart fromtesting correct functionality I also debugged to check that Maps created correctly where they should but also that in the cases where the async command must be persisted and later on retrieved and deserialized by gson everything works ok and does what and where is expected. An example based on the comment by Alena:
http://localhost:8096/client/api?command=createTags&resourceids=ids&resourcetype=type&tags[0].key=region&tags[0].value=canada
Also other examples like
http://localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire


Thanks,

Antonio Fornie


--===============6384479696784336137==--