Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A05DF10356 for ; Thu, 6 Mar 2014 13:50:01 +0000 (UTC) Received: (qmail 92161 invoked by uid 500); 6 Mar 2014 13:49:59 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 92051 invoked by uid 500); 6 Mar 2014 13:49:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 92036 invoked by uid 99); 6 Mar 2014 13:49:57 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Mar 2014 13:49:57 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id AEDB51D4BF6; Thu, 6 Mar 2014 13:49:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2898383807364957354==" MIME-Version: 1.0 Subject: Re: Review Request 18733: Refactor DbUpgradeUtils From: "daan Hoogland" To: "daan Hoogland" , "Hugo Trippaers" , "Alena Prokharchyk" Cc: "Miguel Ferreira" , "cloudstack" Date: Thu, 06 Mar 2014 13:49:55 -0000 Message-ID: <20140306134955.2625.75111@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "daan Hoogland" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/18733/ X-Sender: "daan Hoogland" References: <20140304161345.10116.34833@reviews.apache.org> In-Reply-To: <20140304161345.10116.34833@reviews.apache.org> Reply-To: "daan Hoogland" X-ReviewRequest-Repository: cloudstack-git --===============2898383807364957354== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18733/#review36356 ----------------------------------------------------------- Ship it! ea0dec77d98e14e47ca715c46cd0316faa37844c (not that behavior has changed slighty as per Miguel's comment) - daan Hoogland On March 4, 2014, 4:13 p.m., Miguel Ferreira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18733/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 4:13 p.m.) > > > Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Refactor DbUpgradeUtils > > - Move database access code to new class DatabaseAccessObject. This was done to ease the effort of testing, since DbUpgradeUtils has a static API and it is harder to mock static things with Mockito. > - Log exceptions even if ignored. > - Add unit tests for both DbUpgradeUtils and DatabaseAccessObject. > - DbUpgradeUtils.dropTableColumnsIfExist(...) no longer throws CloudRuntimeException to make it consistent with the other methods in the class. > > > Diffs > ----- > > engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java PRE-CREATION > engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java af23b87 > engine/schema/test/com/cloud/upgrade/dao/DatabaseAccessObjectTest.java PRE-CREATION > engine/schema/test/com/cloud/upgrade/dao/DbUpgradeUtilsTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/18733/diff/ > > > Testing > ------- > > Ran all unit tests in eclipse. > Ran "mvn clean install". > > > Thanks, > > Miguel Ferreira > > --===============2898383807364957354==--