Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 22CC5106B9 for ; Tue, 4 Mar 2014 21:02:47 +0000 (UTC) Received: (qmail 74914 invoked by uid 500); 4 Mar 2014 21:02:46 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 74869 invoked by uid 500); 4 Mar 2014 21:02:46 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 74857 invoked by uid 99); 4 Mar 2014 21:02:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Mar 2014 21:02:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4CAED1D4B8B; Tue, 4 Mar 2014 21:02:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1613981023105835532==" MIME-Version: 1.0 Subject: Re: Review Request 18673: Return failure for StartCommand and PrepareForMigrationCommand if storage adaptor fails to connect disks From: "Brian Angus" To: "Brian Angus" , "Mike Tutkowski" Cc: "Marcus Sorensen" , "cloudstack" Date: Tue, 04 Mar 2014 21:02:44 -0000 Message-ID: <20140304210244.10116.24362@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Angus" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/18673/ X-Sender: "Brian Angus" References: <20140303000945.13276.22100@reviews.apache.org> In-Reply-To: <20140303000945.13276.22100@reviews.apache.org> Reply-To: "Brian Angus" X-ReviewRequest-Repository: cloudstack-git --===============1613981023105835532== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18673/#review36162 ----------------------------------------------------------- Ship it! Ship It! - Brian Angus On March 3, 2014, 12:09 a.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18673/ > ----------------------------------------------------------- > > (Updated March 3, 2014, 12:09 a.m.) > > > Review request for cloudstack, Brian Angus and Mike Tutkowski. > > > Bugs: cloudstack-6192 > https://issues.apache.org/jira/browse/cloudstack-6192 > > > Repository: cloudstack-git > > > Description > ------- > > I've noticed that during migrations or vm deployments, if connectPhysicalDisk fails, the system continues with trying to do the start and/or migration. This would cancel vm start if the storage adaptor tells us that the pre-work of connecting the disks has failed. > > > Diffs > ----- > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java e6c750b > > Diff: https://reviews.apache.org/r/18673/diff/ > > > Testing > ------- > > Still running > > > Thanks, > > Marcus Sorensen > > --===============1613981023105835532==--