cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajesh Battala <rajesh.batt...@citrix.com>
Subject RE: Just checked in a minor change to the DB
Date Mon, 10 Mar 2014 06:11:51 GMT
I prefer server side hook because ppl use mail clients in mobiles/web etc and applying client
side rules is not effective.
And moreover we need to keep exporting this client side rule and associated mail client support
is required for the same.
Best option is to have a server side hook . 

Thanks
Rajesh Battala

-----Original Message-----
From: Rajani Karuturi [mailto:Rajani.Karuturi@citrix.com] 
Sent: Monday, March 10, 2014 10:46 AM
To: dev@cloudstack.apache.org
Subject: Re: Just checked in a minor change to the DB


I think a local rule in the mail client on the git commit mails which filters all the mails
from commits@cloudstack.apache.org and which has setup/db/db/schema-*.sql in the content should
work 



~Rajani



On 09-Mar-2014, at 12:32 am, Daan Hoogland <daan.hoogland@gmail.com> wrote:

> in theory, we will have to set up a git (post or pre)  commit hook 
> that parses the contents and amend the comment if a .sql is found. I 
> do not know if we need extra rights from infra or whether our commit 
> bit is enough. I won't be having a look for that this weekend. hope to 
> get time next week.
> 
> 
> On Sat, Mar 8, 2014 at 7:55 PM, Mike Tutkowski 
> <mike.tutkowski@solidfire.com> wrote:
>> Sounds good - Who knows how to set that up?
>> 
>> 
>> On Sat, Mar 8, 2014 at 6:55 AM, Rajesh Battala <rajesh.battala@citrix.com>wrote:
>> 
>>> Yes.. there might be  chance to miss out to inform if we need to do 
>>> manually. If we automate it with git it would be awesome..
>>> 
>>> -----Original Message-----
>>> From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
>>> Sent: Saturday, March 8, 2014 2:21 PM
>>> To: dev
>>> Subject: Re: Just checked in a minor change to the DB
>>> 
>>> We have git spam so we should just use that I think. we could add to 
>>> it by automatically let git add the tag when any sql is touched... I 
>>> like the automated approach of tagging/spamming. It would remove the 
>>> need to manually add the ..-CHANGE tags. I not very much for more 
>>> automated mails to dev, the ones to commits and issues should be enough.
>>> 
>>> On Sat, Mar 8, 2014 at 7:07 AM, Mike Tutkowski < 
>>> mike.tutkowski@solidfire.com> wrote:
>>>> We could, but some schema changes won't impact others.
>>>> 
>>>> For example, if I removed a column and took out the corresponding 
>>>> Java code and you updated your code, the new code wouldn't fail 
>>>> against your old schema.
>>>> 
>>>> People might also update the schema and check it in, but not update 
>>>> the Java code until later.
>>>> 
>>>> Perhaps these are corner cases and it would be fine to have Git 
>>>> notify
>>> us?
>>>> 
>>>> What do people think?
>>>> 
>>>> 
>>>> On Fri, Mar 7, 2014 at 10:51 PM, Rajesh Battala
>>>> <rajesh.battala@citrix.com>wrote:
>>>> 
>>>>> Just a thought, instead of sending mail manually, can't we have a 
>>>>> git hook to send out mail to dev list when there is a commit to 
>>>>> schema
>>> files.
>>>>> So that git will take care of informing the dev about new schema
>>> changes.!
>>>>> 
>>>>> Thanks
>>>>> Rajesh Battala
>>>>> 
>>>>> -----Original Message-----
>>>>> From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
>>>>> Sent: Saturday, March 8, 2014 3:21 AM
>>>>> To: dev
>>>>> Subject: Re: Just checked in a minor change to the DB
>>>>> 
>>>>> saw, good, will do some more if I think of them as well, as well 
>>>>> as add to the descriptions
>>>>> 
>>>>> On Fri, Mar 7, 2014 at 9:29 PM, Mike Tutkowski < 
>>>>> mike.tutkowski@solidfire.com> wrote:
>>>>>> I went ahead and added to the Wiki page you created a few more 
>>>>>> tags that I've seen us use from time to time.
>>>>>> 
>>>>>> 
>>>>>> On Fri, Mar 7, 2014 at 12:37 PM, Mike Tutkowski < 
>>>>>> mike.tutkowski@solidfire.com> wrote:
>>>>>> 
>>>>>>> Great! Thanks, Daan
>>>>>>> 
>>>>>>> I also agree that it would be useful info to have in commit messages.
>>>>>>> 
>>>>>>> 
>>>>>>> On Fri, Mar 7, 2014 at 12:14 PM, Daan Hoogland 
>>>>>>> <daan.hoogland@gmail.com
>>>>>> wrote:
>>>>>>> 
>>>>>>>> I created
>>>>>>>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/mail+tag
>>>>>>>> s+
>>>>>>>> to+
>>>>>>>> use+to+help+each+other
>>>>>>>> below the path
>>>>>>>> Apache Cloudstack / Home / Community / Getting Help
>>>>>>>> 
>>>>>>>> 
>>>>>>>> On Fri, Mar 7, 2014 at 8:03 PM, Daan Hoogland 
>>>>>>>> <daan.hoogland@gmail.com>
>>>>>>>> wrote:
>>>>>>>>> I had a quick look. Nothing found but a lot of hits on
tags of
>>>>> course.
>>>>>>>>> I'll try to find a place to create the page and start
chapters 
>>>>>>>>> on Dev and Users
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> On Fri, Mar 7, 2014 at 7:54 PM, Daan Hoogland 
>>>>>>>>> <daan.hoogland@gmail.com>
>>>>>>>> wrote:
>>>>>>>>>> No, but I do know that it might be useful to use
them in 
>>>>>>>>>> commit comments as well. If you so feel inclined
you can 
>>>>>>>>>> refer to that as well
>>>>>>>>>> 
>>>>>>>>>> On Fri, Mar 7, 2014 at 7:41 PM, Mike Tutkowski 
>>>>>>>>>> <mike.tutkowski@solidfire.com> wrote:
>>>>>>>>>>> Does anyone know if our e-mail tags are documented
on the Wiki?
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> On Fri, Mar 7, 2014 at 11:36 AM, Mike Tutkowski
< 
>>>>>>>>>>> mike.tutkowski@solidfire.com> wrote:
>>>>>>>>>>> 
>>>>>>>>>>>> That sounds good, Daan.
>>>>>>>>>>>> 
>>>>>>>>>>>> Let's use both tags.
>>>>>>>>>>>> 
>>>>>>>>>>>> Thanks!
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> On Fri, Mar 7, 2014 at 9:33 AM, Daan Hoogland
<
>>>>>>>> daan.hoogland@gmail.com>wrote:
>>>>>>>>>>>> 
>>>>>>>>>>>>> Absolutaly,
>>>>>>>>>>>>> 
>>>>>>>>>>>>> But I meant for us to use both tags.
I checked in a commit 
>>>>>>>>>>>>> (that I didn't give a head up on) for
a colleague in which 
>>>>>>>>>>>>> a CloudRuntimeException was removed to
be more consistent 
>>>>>>>>>>>>> with the
>>>>>>>> rest
>>>>>>>>>>>>> of the code. It was only effecting th
upgrade process in 
>>>>>>>>>>>>> this case
>>>>>>>> but
>>>>>>>>>>>>> still;
>>>>>>>>>>>>> [BEHAVIORAL-CHANGE] was caused. Of course
these heads-up 
>>>>>>>>>>>>> will always be an inter developer courtesy
but here is 
>>>>>>>>>>>>> mine (hidden in some one elses thread;)
>>>>>>>>>>>>> 
>>>>>>>>>>>>> so in short i meant and and not or, Daan
>>>>>>>>>>>>> 
>>>>>>>>>>>>> 
>>>>>>>>>>>>> On Fri, Mar 7, 2014 at 4:20 PM, Mike
Tutkowski 
>>>>>>>>>>>>> <mike.tutkowski@solidfire.com>
wrote:
>>>>>>>>>>>>>> I like either tag.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Since DB changes are the most likely
to lead to breaking 
>>>>>>>>>>>>>> other
>>>>>>>> people's
>>>>>>>>>>>>>> environments, maybe we should go
with that one:
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> [DB-CHANGE]
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Ideally we'd provide the branch,
commit SHA, and a manual 
>>>>>>>>>>>>>> way
>>>>>>>> around
>>>>>>>>>>>>> it, if
>>>>>>>>>>>>>> there is something simple (like in
my case yesterday, 
>>>>>>>>>>>>>> simply
>>>>>>>> deleting
>>>>>>>>>>>>> and
>>>>>>>>>>>>>> re-creating two views). If there's
no easy way around it, 
>>>>>>>>>>>>>> then
>>>>>>>> don't
>>>>>>>>>>>>> bother
>>>>>>>>>>>>>> providing that.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Sound reasonable?
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> On Fri, Mar 7, 2014 at 2:12 AM, Daan
Hoogland <
>>>>>>>> daan.hoogland@gmail.com
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> Thanks for the heads up Mike,
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> As discussed in your thread [1].
You are eating your own
>>>>> dogfood
>>>>>>>> here.
>>>>>>>>>>>>>>> I was checking in a minor change
to the upgrade handling
>>>>>>>> yesterday and
>>>>>>>>>>>>>>> decided not to bother everyone
with it. evil me. In that
>>>>> thread
>>>>>>>> we
>>>>>>>>>>>>>>> didn't dicide on a tag, yet.
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> I would suggest
>>>>>>>>>>>>>>> [DB-CHANGE] and
>>>>>>>>>>>>>>> [BEHAVIORAL-CHANGE]
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> [1] http://markmail.org/message/r7wv36o356nolq7f
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> On Thu, Mar 6, 2014 at 9:05 PM,
Mike Tutkowski 
>>>>>>>>>>>>>>> <mike.tutkowski@solidfire.com>
wrote:
>>>>>>>>>>>>>>>> Hi everyone,
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> Just wanted to give you a
heads up that I made a minor
>>>>> change
>>>>>>>> to two
>>>>>>>>>>>>>>> views
>>>>>>>>>>>>>>>> in the DB in 9b66866dc2085486f465159cbd446ac03e266a2c:
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> service_offering_view and
disk_offering_view
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> I added some columns to these
views so I could present
>>>>>>>> additional
>>>>>>>>>>>>> info in
>>>>>>>>>>>>>>>> the GUI.
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> If you want to bring these
two views up to date, just 
>>>>>>>>>>>>>>>> run
>>>>> the
>>>>>>>>>>>>> following
>>>>>>>>>>>>>>> SQL:
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> DROP VIEW IF EXISTS `cloud`.`disk_offering_view`;

>>>>>>>>>>>>>>>> CREATE VIEW `cloud`.`disk_offering_view`
AS
>>>>>>>>>>>>>>>>    select
>>>>>>>>>>>>>>>>        disk_offering.id,
>>>>>>>>>>>>>>>>        disk_offering.uuid,
>>>>>>>>>>>>>>>>        disk_offering.name,
>>>>>>>>>>>>>>>>        disk_offering.display_text,
>>>>>>>>>>>>>>>>        disk_offering.disk_size,
>>>>>>>>>>>>>>>>        disk_offering.min_iops,
>>>>>>>>>>>>>>>>        disk_offering.max_iops,
>>>>>>>>>>>>>>>>        disk_offering.created,
>>>>>>>>>>>>>>>>        disk_offering.tags,
>>>>>>>>>>>>>>>>        disk_offering.customized,
>>>>>>>>>>>>>>>>        disk_offering.customized_iops,
>>>>>>>>>>>>>>>>        disk_offering.removed,
>>>>>>>>>>>>>>>>        disk_offering.use_local_storage,
>>>>>>>>>>>>>>>>        disk_offering.system_use,
>>>>>>>>>>>>>>>>        disk_offering.hv_ss_reserve,
>>>>>>>>>>>>>>>>        disk_offering.bytes_read_rate,
>>>>>>>>>>>>>>>>        disk_offering.bytes_write_rate,
>>>>>>>>>>>>>>>>        disk_offering.iops_read_rate,
>>>>>>>>>>>>>>>>        disk_offering.iops_write_rate,
>>>>>>>>>>>>>>>>        disk_offering.cache_mode,
>>>>>>>>>>>>>>>>        disk_offering.sort_key,
>>>>>>>>>>>>>>>>        disk_offering.type,
>>>>>>>>>>>>>>>>        disk_offering.display_offering,
>>>>>>>>>>>>>>>>        domain.id domain_id,
>>>>>>>>>>>>>>>>        domain.uuid domain_uuid,
>>>>>>>>>>>>>>>>        domain.name domain_name,
>>>>>>>>>>>>>>>>        domain.path domain_path
>>>>>>>>>>>>>>>>    from
>>>>>>>>>>>>>>>>        `cloud`.`disk_offering`
>>>>>>>>>>>>>>>>            left join
>>>>>>>>>>>>>>>>        `cloud`.`domain` ON
disk_offering.domain_id =
>>>>>>>> domain.id
>>>>>>>>>>>>>>>>    where
>>>>>>>>>>>>>>>>        disk_offering.state='ACTIVE';
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> DROP VIEW IF EXISTS `cloud`.`service_offering_view`;

>>>>>>>>>>>>>>>> CREATE VIEW `cloud`.`service_offering_view`
AS
>>>>>>>>>>>>>>>>    select
>>>>>>>>>>>>>>>>        service_offering.id,
>>>>>>>>>>>>>>>>        disk_offering.uuid,
>>>>>>>>>>>>>>>>        disk_offering.name,
>>>>>>>>>>>>>>>>        disk_offering.display_text,
>>>>>>>>>>>>>>>>        disk_offering.created,
>>>>>>>>>>>>>>>>        disk_offering.tags,
>>>>>>>>>>>>>>>>        disk_offering.removed,
>>>>>>>>>>>>>>>>        disk_offering.use_local_storage,
>>>>>>>>>>>>>>>>        disk_offering.system_use,
>>>>>>>>>>>>>>>>        disk_offering.customized_iops,
>>>>>>>>>>>>>>>>        disk_offering.min_iops,
>>>>>>>>>>>>>>>>        disk_offering.max_iops,
>>>>>>>>>>>>>>>>        disk_offering.hv_ss_reserve,
>>>>>>>>>>>>>>>>        disk_offering.bytes_read_rate,
>>>>>>>>>>>>>>>>        disk_offering.bytes_write_rate,
>>>>>>>>>>>>>>>>        disk_offering.iops_read_rate,
>>>>>>>>>>>>>>>>        disk_offering.iops_write_rate,
>>>>>>>>>>>>>>>>        disk_offering.cache_mode,
>>>>>>>>>>>>>>>>        service_offering.cpu,
>>>>>>>>>>>>>>>>        service_offering.speed,
>>>>>>>>>>>>>>>>        service_offering.ram_size,
>>>>>>>>>>>>>>>>        service_offering.nw_rate,
>>>>>>>>>>>>>>>>        service_offering.mc_rate,
>>>>>>>>>>>>>>>>        service_offering.ha_enabled,
>>>>>>>>>>>>>>>>        service_offering.limit_cpu_use,
>>>>>>>>>>>>>>>>        service_offering.host_tag,
>>>>>>>>>>>>>>>>        service_offering.default_use,
>>>>>>>>>>>>>>>>        service_offering.vm_type,
>>>>>>>>>>>>>>>>        service_offering.sort_key,
>>>>>>>>>>>>>>>>        service_offering.is_volatile,
>>>>>>>>>>>>>>>>        service_offering.deployment_planner,
>>>>>>>>>>>>>>>>        domain.id domain_id,
>>>>>>>>>>>>>>>>        domain.uuid domain_uuid,
>>>>>>>>>>>>>>>>        domain.name domain_name,
>>>>>>>>>>>>>>>>        domain.path domain_path
>>>>>>>>>>>>>>>>    from
>>>>>>>>>>>>>>>>        `cloud`.`service_offering`
>>>>>>>>>>>>>>>>            inner join
>>>>>>>>>>>>>>>>        `cloud`.`disk_offering`
ON service_offering.id =
>>>>>>>>>>>>>>> disk_offering.id
>>>>>>>>>>>>>>>>            left join
>>>>>>>>>>>>>>>>        `cloud`.`domain` ON
disk_offering.domain_id =
>>>>>>>> domain.id
>>>>>>>>>>>>>>>>    where
>>>>>>>>>>>>>>>>        disk_offering.state='Active';
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> Thanks!
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>> *Mike Tutkowski*
>>>>>>>>>>>>>>>> *Senior CloudStack Developer,
SolidFire Inc.*
>>>>>>>>>>>>>>>> e: mike.tutkowski@solidfire.com
>>>>>>>>>>>>>>>> o: 303.746.7302
>>>>>>>>>>>>>>>> Advancing the way the world
uses the 
>>>>>>>>>>>>>>>> cloud<http://solidfire.com/solution/overview/?video=pl
>>>>>>>>>>>>>>>> ay>
>>>>>>>>>>>>>>>> *(tm)*
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> Daan
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> *Mike Tutkowski*
>>>>>>>>>>>>>> *Senior CloudStack Developer, SolidFire
Inc.*
>>>>>>>>>>>>>> e: mike.tutkowski@solidfire.com
>>>>>>>>>>>>>> o: 303.746.7302
>>>>>>>>>>>>>> Advancing the way the world uses
the 
>>>>>>>>>>>>>> cloud<http://solidfire.com/solution/overview/?video=play>
>>>>>>>>>>>>>> *(tm)*
>>>>>>>>>>>>> 
>>>>>>>>>>>>> 
>>>>>>>>>>>>> 
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Daan
>>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> 
>>>>>>>>>>>> --
>>>>>>>>>>>> *Mike Tutkowski*
>>>>>>>>>>>> *Senior CloudStack Developer, SolidFire Inc.*
>>>>>>>>>>>> e: mike.tutkowski@solidfire.com
>>>>>>>>>>>> o: 303.746.7302
>>>>>>>>>>>> Advancing the way the world uses the cloud<
>>>>>>>> http://solidfire.com/solution/overview/?video=play>
>>>>>>>>>>>> *(tm)*
>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> --
>>>>>>>>>>> *Mike Tutkowski*
>>>>>>>>>>> *Senior CloudStack Developer, SolidFire Inc.*
>>>>>>>>>>> e: mike.tutkowski@solidfire.com
>>>>>>>>>>> o: 303.746.7302
>>>>>>>>>>> Advancing the way the world uses the 
>>>>>>>>>>> cloud<http://solidfire.com/solution/overview/?video=play>
>>>>>>>>>>> *(tm)*
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>>> --
>>>>>>>>>> Daan
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> --
>>>>>>>>> Daan
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>>>> --
>>>>>>>> Daan
>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> --
>>>>>>> *Mike Tutkowski*
>>>>>>> *Senior CloudStack Developer, SolidFire Inc.*
>>>>>>> e: mike.tutkowski@solidfire.com
>>>>>>> o: 303.746.7302
>>>>>>> Advancing the way the world uses the cloud<
>>>>> http://solidfire.com/solution/overview/?video=play>
>>>>>>> *(tm)*
>>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> *Mike Tutkowski*
>>>>>> *Senior CloudStack Developer, SolidFire Inc.*
>>>>>> e: mike.tutkowski@solidfire.com
>>>>>> o: 303.746.7302
>>>>>> Advancing the way the world uses the 
>>>>>> cloud<http://solidfire.com/solution/overview/?video=play>
>>>>>> *(tm)*
>>>>> 
>>>>> 
>>>>> 
>>>>> --
>>>>> Daan
>>>>> 
>>>> 
>>>> 
>>>> 
>>>> --
>>>> *Mike Tutkowski*
>>>> *Senior CloudStack Developer, SolidFire Inc.*
>>>> e: mike.tutkowski@solidfire.com
>>>> o: 303.746.7302
>>>> Advancing the way the world uses the 
>>>> cloud<http://solidfire.com/solution/overview/?video=play>
>>>> *(tm)*
>>> 
>>> 
>>> 
>>> --
>>> Daan
>>> 
>> 
>> 
>> 
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkowski@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the
>> cloud<http://solidfire.com/solution/overview/?video=play>
>> *(tm)*
> 
> 
> 
> --
> Daan


Mime
View raw message