cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastien Goasguen" <run...@gmail.com>
Subject Re: Review Request 19635: CLOUDSTACK-6015: Add tests for adding/deleting new user account, adding/deleting user.
Date Fri, 28 Mar 2014 10:25:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19635/#review38888
-----------------------------------------------------------

Ship it!


Committed to master with 9b07979442c251438004bfb0781dee85a5c29100

Please fix pep8 issues in all python scripts in a follow up patch

thanks

You can mark this review as submitted

- Sebastien Goasguen


On March 25, 2014, 8:58 p.m., Yichi Lu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19635/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 8:58 p.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6015
> Following tests are new (need to be run in the order displayed):
> adduseraccount_test.py
> adduser_test.py
> login_logout_as_JohnD_test.py    (new account's username is JohnD)
> deleteuser_test.py
> deleteuseraccount_test.py
> 
> 
> Diffs
> -----
> 
>   test/selenium/common/shared.py b4f537f 
>   test/selenium/cspages/accounts/accountspage.py PRE-CREATION 
>   test/selenium/cspages/accounts/userspage.py PRE-CREATION 
>   test/selenium/cspages/cspage.py PRE-CREATION 
>   test/selenium/cspages/dashboard/dashboardpage.py 4394199 
>   test/selenium/cspages/login/loginpage.py e7795d9 
>   test/selenium/cstests/smoketests/adduser_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/adduseraccount_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/deleteuser_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/deleteuseraccount_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/login_logout_as_JohnD_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/smokecfg.py 8bbb350 
> 
> Diff: https://reviews.apache.org/r/19635/diff/
> 
> 
> Testing
> -------
> 
> tested against CloudStack 4.5.0-SNAPSHOT. Patch generated against the latest master.
> (Hope this time I did it right)
> 
> 
> Thanks,
> 
> Yichi Lu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message