cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damodar Reddy Talakanti" <damoder.re...@citrix.com>
Subject Review Request 19780: [Windows] Check dependencies are installed or not through registry instead of environment variables
Date Fri, 28 Mar 2014 06:51:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19780/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and daan Hoogland.


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6291
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6291


Repository: cloudstack-git


Description
-------

Previously we were checking environment variables to decide the needed dependencies are installed
or not. This will some extra effort to the admin to set them before start installation of
ACS. So removed that dependency and checking through registry to verify the same.


Diffs
-----

  scripts/installer/windows/acs.wxs 9456a5a 

Diff: https://reviews.apache.org/r/19780/diff/


Testing
-------

Tested on windows 2008R2 instance. Tested for the following use cases
1. Java is not installed
2. tomcat is not installed
3. 7z is not installed.


Thanks,

Damodar Reddy Talakanti


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message