cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Suich" <chris.su...@netapp.com>
Subject Re: Review Request 19460: Check for returned null, throw exception rather than continue.
Date Thu, 20 Mar 2014 14:48:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19460/#review37891
-----------------------------------------------------------

Ship it!


Ship It!

- Chris Suich


On March 20, 2014, 2:42 p.m., Alex Hitchins wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19460/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 2:42 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-5825
> 
> I've added a check for null returned. Previously it would return even though there were
errors. If null is returned, the takeSnapshot raised and caught an exception. I check for
null and if received throw a new exception rather than continue the flow.
> 
> 
> Diffs
> -----
> 
>   engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java
68e5a56 
> 
> Diff: https://reviews.apache.org/r/19460/diff/
> 
> 
> Testing
> -------
> 
> Compiled and deployed on a new test system, completed steps and snapshots created successfully.

> 
> I could not re-create a snapshot error, however normal operation is as expected. It's
better it throws an exception rather than continue to log it's successful when it's not.
> 
> 
> Thanks,
> 
> Alex Hitchins
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message