cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
Date Thu, 20 Mar 2014 13:54:34 GMT


> On March 19, 2014, 11:09 a.m., daan Hoogland wrote:
> > Damoder,
> > 
> > You introduced some trailing whitespace in this version of the diff.
> > As far as I can judge it it looks alright.
> > One remark I have: scripts/installer/windows/client.wxs looks like it is generated
by some tool from some source. Is it? Can we include that source instead?
> 
> Damodar Reddy Talakanti wrote:
>     Hi Daan,
>     
>      Yes client.wxs is generated by Wix Tool. Actually it is a command line command to
generate that source file. At the max I can put a readme file to include those commands to
geenerate this file. I already posted these commands on FS. What do you suggest? Shall we
remove that file and simply put a readme

If the source from which it is generated is already in the cloudstack source tree, we shouldn't
include this 'intermediate' file. The README can be included for convenience. Having the commands
in the documentation is more important.


- daan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/#review37703
-----------------------------------------------------------


On March 18, 2014, 1:46 p.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18964/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 1:46 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and
Donal Lafferty.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Windowsfication of CloudStack Management Server
> 
> 
> Diffs
> -----
> 
>   scripts/installer/windows/acs.wxs PRE-CREATION 
>   scripts/installer/windows/client.wxs PRE-CREATION 
>   scripts/installer/windows/start.bat PRE-CREATION 
>   scripts/vm/systemvm/injectkeys.py PRE-CREATION 
>   server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 
>   server/test/com/cloud/server/ConfigurationServerImplTest.java 08a2097 
> 
> Diff: https://reviews.apache.org/r/18964/diff/
> 
> 
> Testing
> -------
> 
> Tested in Linux environment after changes 
> Also tested in Windows environment(For now tested on windows-8) to make sure it is getting
installed and management service is running.
> 
> Able to add zones, able to register templates, able to launch a VM when it is running
on windows.
> 
> Currently though it is getting added as a windows service, not able to start the service
through windows service control manager which I am looking into currently. When run .exe file
which is installed then server is getting up and able to access cloud stack UI. 
> 
> For now The following assumptions are made:
> 1. SSH keys are already installed
> 2. JAVA is already installed
> 3. tomcat is already installed
> 
> This patch contains the following new files related to WiX tool (To compile and run we
need this tool)
> 1. acs.wxs
>     The following command will be used to compile
>       "<Path To WiX Tool>\bin\candle.exe" acs.wxs
> 2. client.wxs
>     The following command will be used to generate the above file
>       "<Path To WiX Tool>\bin\heat" dir client -gg -cg Test  -ke -sfrag -template
fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
>     The following command will be used to compile the above generated file
>       "<Path To WiX Tool>\bin\candle.exe" client.wxs
> 3. The following command will be used to generate .msi file
>       "<Path To WiX Tool>\bin\light.exe" acs.wixobj client.wixobj -out acs.msi
 -ext "C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll" -dSourceClient=SourceDir\client
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message