cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Hitchins" <>
Subject Review Request 19460: Check for returned null, throw exception rather than continue.
Date Thu, 20 Mar 2014 12:00:59 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for cloudstack.

Repository: cloudstack-git


I've added a check for null returned. Previously it would return even though there were errors.
If null is returned, the takeSnapshot raised and caught an exception. I check for null and
if received throw a new exception rather than continue the flow.


  server/src/com/cloud/storage/ 5ffa99b 



Compiled and deployed on a new test system, completed steps and snapshots created successfully.

I could not re-create a snapshot error, however normal operation is as expected. It's better
it throws an exception rather than continue to log it's successful when it's not.


Alexander Hitchins

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message