cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sonal Ojha" <sonal.o...@sungard.com>
Subject Re: Review Request 18677: CLOUDSTACK-3272
Date Wed, 19 Mar 2014 14:57:39 GMT


> On March 18, 2014, 11:38 a.m., Murali Reddy wrote:
> > plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java,
line 244
> > <https://reviews.apache.org/r/18677/diff/1/?file=507875#file507875line244>
> >
> >     Please use String.Equals method than '=='

I will make this change.


> On March 18, 2014, 11:38 a.m., Murali Reddy wrote:
> > plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java,
lines 246-254
> > <https://reviews.apache.org/r/18677/diff/1/?file=507875#file507875line246>
> >
> >     Why not filter at the source where events gets published it self instead of
filtering in the plug-ins?
> >     
> >     For e.g. in ActionEventUtils.publishOnEventBus you could check the config value
'publish.action.events' and then decide to publish or not.

I tried moving to the ActionEventUtils but facing issue instantiating ConfigurationDao, it
doesn't give any error while building but even after injecting the dao the object is null
and so gives a NullPointerException.


- Sonal


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18677/#review37548
-----------------------------------------------------------


On March 4, 2014, 5:51 a.m., Sonal Ojha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18677/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 5:51 a.m.)
> 
> 
> Review request for cloudstack, Chiradeep Vittal and Murali Reddy.
> 
> 
> Bugs: CLOUDSTACK-3272
>     https://issues.apache.org/jira/browse/CLOUDSTACK-3272
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> At present, there are multiple event types that are generated by CS, action events,usage
events, resource state change events and alerts. Current problem is
> all the events gets published on the event bus when event bus is enabled. Intent is to
introduce global setting config parameters to specify which category of events to be published
or not be published on the event bus.
> 
> 
> Diffs
> -----
> 
>   plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
478c8d7 
>   server/src/com/cloud/configuration/Config.java 2d55f46 
>   server/src/com/cloud/test/DatabaseConfig.java 9370218 
> 
> Diff: https://reviews.apache.org/r/18677/diff/
> 
> 
> Testing
> -------
> 
> Successfully tested publishing / not publishing of various events based on the global
parameter publish.*.events.
> 
> 
> Thanks,
> 
> Sonal Ojha
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message