cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 18964: Windowsfication of CloudStack Management Server - Changes to support windows OS
Date Fri, 14 Mar 2014 09:58:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18964/#review37186
-----------------------------------------------------------


Can you add some doc or ref to doc that explains how to test this on windows.


scripts/installer/windows/acs.wxs
<https://reviews.apache.org/r/18964/#comment68601>

    don't forget the apache license header here



scripts/installer/windows/acs.wxs
<https://reviews.apache.org/r/18964/#comment68602>

    tabs and trailing whitespace



scripts/installer/windows/acs.wxs
<https://reviews.apache.org/r/18964/#comment68603>

    tabs and trailing whitespace



scripts/installer/windows/acs.wxs
<https://reviews.apache.org/r/18964/#comment68604>

    tabs and trailing whitespace



scripts/installer/windows/acs.wxs
<https://reviews.apache.org/r/18964/#comment68605>

    tabs and trailing whitespace



scripts/installer/windows/client.wxs
<https://reviews.apache.org/r/18964/#comment68606>

    license header needed



scripts/installer/windows/start.bat
<https://reviews.apache.org/r/18964/#comment68607>

    licene header



scripts/vm/systemvm/injectkeys.py
<https://reviews.apache.org/r/18964/#comment68608>

    tabs and trailing whitespace



scripts/vm/systemvm/injectkeys.py
<https://reviews.apache.org/r/18964/#comment68609>

    tabs and trailing whitespace



scripts/vm/systemvm/injectkeys.py
<https://reviews.apache.org/r/18964/#comment68610>

    tabs and trailing whitespace



scripts/vm/systemvm/injectkeys.py
<https://reviews.apache.org/r/18964/#comment68611>

    tabs and trailing whitespace



scripts/vm/systemvm/injectkeys.py
<https://reviews.apache.org/r/18964/#comment68612>

    tabs and trailing whitespace



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68621>

    as the test is for "windows" all the time, a var named isWindows or onWindows may be in
order.
    Also mocked tests to show that the right paths are taken would be nice.



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68613>

    tab



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68614>

    tab



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68617>

    why is this condition needed if both the if and the else branch take the same action.



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68615>

    tab
    should windows scripts be named with forward slashes? Maybe a path generated from File
object(s)



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68616>

    tb



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68618>

    tab



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68619>

    tab



server/src/com/cloud/server/ConfigurationServerImpl.java
<https://reviews.apache.org/r/18964/#comment68620>

    tab


- daan Hoogland


On March 14, 2014, 9:42 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18964/
> -----------------------------------------------------------
> 
> (Updated March 14, 2014, 9:42 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Chiradeep Vittal, daan Hoogland, and
Donal Lafferty.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6105
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6105
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Windowsfication of CloudStack Management Server
> 
> 
> Diffs
> -----
> 
>   scripts/installer/windows/acs.wxs PRE-CREATION 
>   scripts/installer/windows/client.wxs PRE-CREATION 
>   scripts/installer/windows/start.bat PRE-CREATION 
>   scripts/vm/systemvm/injectkeys.py PRE-CREATION 
>   server/src/com/cloud/server/ConfigurationServerImpl.java b8da4c8 
> 
> Diff: https://reviews.apache.org/r/18964/diff/
> 
> 
> Testing
> -------
> 
> Tested in Linux environment after changes 
> Also tested in Windows environment(For now tested on windows-8) to make sure it is getting
installed and management service is running.
> 
> Able to add zones, able to register templates, able to launch a VM when it is running
on windows.
> 
> Currently though it is getting added as a windows service, not able to start the service
through windows service control manager which I am looking into currently. When run .exe file
which is installed then server is getting up and able to access cloud stack UI. 
> 
> For now The following assumptions are made:
> 1. SSH keys are already installed
> 2. JAVA is already installed
> 3. tomcat is already installed
> 
> This patch contains the following new files related to WiX tool (To compile and run we
need this tool)
> 1. acs.wxs
>     The following command will be used to compile
>       "<Path To WiX Tool>\bin\candle.exe" acs.wxs
> 2. client.wxs
>     The following command will be used to generate the above file
>       "<Path To WiX Tool>\bin\heat" dir client -gg -cg Test  -ke -sfrag -template
fragment -out client.wxs  -var wix.SourceClient -dr WEBAPPS
>     The following command will be used to compile the above generated file
>       "<Path To WiX Tool>\bin\candle.exe" client.wxs
> 3. The following command will be used to generate .msi file
>       "<Path To WiX Tool>\bin\light.exe" acs.wixobj client.wixobj -out acs.msi
 -ext "C:\Program Files (x86)\WiX Toolset v3.8\bin\WixUIExtension.dll" -dSourceClient=SourceDir\client
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message