cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saksham Srivastava" <saksham.srivast...@citrix.com>
Subject Re: Review Request 14124: CLOUDSTACK-4622 : If a VM from guest network is added to network tier of VPC then IP reservation allows the CIDR to be a superset of Network CIDR for that VPC tier
Date Wed, 12 Mar 2014 14:23:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14124/
-----------------------------------------------------------

(Updated March 12, 2014, 2:23 p.m.)


Review request for cloudstack, Jayapal Reddy and Sateesh Chodapuneedi.


Changes
-------

Adding the output of marvin tests.


Bugs: CLOUDSTACK-4622
    https://issues.apache.org/jira/browse/CLOUDSTACK-4622


Repository: cloudstack-git


Description
-------

Add a new utility method for comparing 2 CIDRs.
The method takes in 2 cidrs, cidrA and cidrB and returns true if cidrA's IP range is equal
or a subset of cidrB's IP range.


Diffs (updated)
-----

  utils/src/com/cloud/utils/net/NetUtils.java 6350986 
  utils/test/com/cloud/utils/net/NetUtilsTest.java 3183826 

Diff: https://reviews.apache.org/r/14124/diff/


Testing (updated)
-------

Added unit test for the utility.
Tested locally.
Build is successful.
Patch applies cleanly.
No FindBug issues.

Results of marvin test: test_vpc.py
Test list VPC APIs ... ok
Test restart VPC having no networks ... ok
Test restart VPC having networks ... ok
Test delete VPC having no networks ... ok
Test delete VPC having networks ... ok
Test list VPC APIs for different user roles ... ok
Test Restart VPC when there are multiple networks associated ... ok
Test vpc deletion after account deletion ... ok
Test to create vpc and verify VPC state, VR and SourceNatIP ... ok
Test creation of multiple VPCs with non-overlapping CIDRs ... ok
Test deployment of vm in a VPC without network domain ... ok
Test deployment of vm in a VPC with network domain ... ok
Test deployment of vm in a VPC with network domain ... ok
Test vm deploy in network by a user where VPC was created without account/domain ID ... ok
Test deployment of vm in a network in a domain admin account where VPC is created without
account/domain ID ... ok
Test deployment of vm in a network by root admin for user. ... ok
Test deployment of vm in a network by domain admin for user. ... ok
Test creation of network by domain admin for user from different domain ... ok
Test creation of VPC without mandatory parameters ... ok
Test to verify updation of vpc name and display text ... ok

few tests from: test_vpc_network.py
Test create network in VPC ... ok
Test create network in VPC ... SKIP: Netscaler not configured: skipping test
Test create network in VPC mismatched services (Should fail) ... ok
Test create multiple networks with LB service (Should fail) ... ok
Test create network with external LB devices ... ok
Test create network with redundant router capability ... SKIP: skipped - RvR didn't support
VPC currently
Test create network services not supported by VPC (Should fail) ... ok
Test create network without sourceNAT service in VPC (should fail) ... ok
Test create network with shared network offering ... ok
Test create network with conserve mode ON ... ok
Test create network with conserve mode ON ... ok
Test network gc after shutdown of vms in the network ... ok
Test network rules after starting a VpcVr that was shutdown after network.gc ... ok
Test Stop all the Vms that are part of the a Network ... ok
Test create network outside cidr range of VPC ... ok
Test create network outside cidr range of VPC ... ok
Test create network inside cidr range of VPC ... ok
Test create network overlapping cidr range of VPC ... ok
Test create network from different account in VPC ... ok
Test update Network that is NOT part of a VPC to a nw offering that has services that are
provided by VPCVR and vice versa ... ok


Thanks,

Saksham Srivastava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message