cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amogh Vasekar" <amogh.vase...@citrix.com>
Subject Re: Review Request 18978: Ability to manipulate guest OS mappings
Date Mon, 10 Mar 2014 20:25:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/
-----------------------------------------------------------

(Updated March 10, 2014, 8:25 p.m.)


Review request for cloudstack and Nitin Mehta.


Changes
-------

Sorry, uploaded an old diff by mistake. 
Request to please review again


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217


Repository: cloudstack-git


Description
-------

Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the
same.


Diffs (updated)
-----

  api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722

  api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596 
  api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676

  api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969

  api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd

  api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION 
  api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION

  api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION 
  client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a 
  engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd

  engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b

  engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044

  engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936

  server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79

  server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3

  setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2 

Diff: https://reviews.apache.org/r/18978/diff/


Testing
-------

Tested on local environment on master branch for all APIs, including some edge cases.


Thanks,

Amogh Vasekar


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message