cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 18894: CLOUDSTACK-6210 LDAP:listLdapUsers api throws exception when we click on "Add LDAP Account"
Date Fri, 07 Mar 2014 17:00:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18894/#review36535
-----------------------------------------------------------


Commit 4552ec632201e7432afae7770f5854aaa244267c in cloudstack's branch refs/heads/master from
Rajani Karuturi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4552ec6 ]

Fixed CLOUDSTACK-6210 LDAP:listLdapUsers api throws exception when we click on "Add LDAP Account"
This occurs when ldap basedn is not configured. Throwing an IAE and a proper message is returned
from the api call

Signed-off-by: Ian Duffy <ian@ianduffy.ie>


- ASF Subversion and Git Services


On March 7, 2014, 6:10 a.m., Rajani Karuturi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18894/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 6:10 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Ian Duffy.
> 
> 
> Bugs: CLOUDSTACK-6210
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6210
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This occurs when ldap basedn is not configured.
> Throwing an IAE and a proper message is returned from the api call
> 
> The api call response earlier was
> { "ldapuserresponse" : {"uuidList":[],"errorcode":530,"cserrorcode":9999} }
> now it is as follows
> { "ldapuserresponse" : {"uuidList":[],"errorcode":431,"cserrorcode":9999,"errortext":"ldap
basedn is not configured"} }
> 
> 
> Diffs
> -----
> 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java
2dacafe 
>   plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy
fa735d3 
> 
> Diff: https://reviews.apache.org/r/18894/diff/
> 
> 
> Testing
> -------
> 
> unittested by adding a new test case "test searchUsers when ldap basedn in not set" in
LdapUserManagerSpec.groovy which reproduces this case 
> 
> manually tested the api call as well
> 
> 
> Thanks,
> 
> Rajani Karuturi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message