cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 18733: Refactor DbUpgradeUtils
Date Thu, 06 Mar 2014 13:49:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18733/#review36356
-----------------------------------------------------------

Ship it!


ea0dec77d98e14e47ca715c46cd0316faa37844c (not that behavior has changed slighty as per Miguel's
comment)

- daan Hoogland


On March 4, 2014, 4:13 p.m., Miguel Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18733/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 4:13 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Refactor DbUpgradeUtils
>     
>       - Move database access code to new class DatabaseAccessObject. This was done to
ease the effort of testing, since DbUpgradeUtils has a static API and it is harder to mock
static things with Mockito.
>       - Log exceptions even if ignored.
>       - Add unit tests for both DbUpgradeUtils and DatabaseAccessObject.
>       - DbUpgradeUtils.dropTableColumnsIfExist(...) no longer throws CloudRuntimeException
to make it consistent with the other methods in the class.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java PRE-CREATION 
>   engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java af23b87 
>   engine/schema/test/com/cloud/upgrade/dao/DatabaseAccessObjectTest.java PRE-CREATION

>   engine/schema/test/com/cloud/upgrade/dao/DbUpgradeUtilsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18733/diff/
> 
> 
> Testing
> -------
> 
> Ran all unit tests in eclipse.
> Ran "mvn clean install".
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message