cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 18683: CLOUDSTACK-6194: Failed to increase Shared network IP Range
Date Wed, 05 Mar 2014 05:20:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18683/#review36210
-----------------------------------------------------------


Commit cd0d16f05a2be02e3de1a327bba9a5acd112e4f2 in cloudstack's branch refs/heads/4.3-forward
from Marcus Sorensen
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=cd0d16f ]

CLOUDSTACK-6194: Failed to increase Shared network IP Range

Submitted-by:Saksham Srivastava <saksham.srivastava@citrix.com>


- ASF Subversion and Git Services


On March 3, 2014, 12:53 p.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18683/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 12:53 p.m.)
> 
> 
> Review request for cloudstack, Marcus Sorensen and Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-6194
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6194
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> In case the vlan is passed null to the api or doing it from UI, the new changes make
vlanId as "vlan://untagged"
> 
> The following code in ConfigurationManagerImpl.java
>  if (vlans != null && vlans.size() > 0) {
>                      VlanVO vlan = vlans.get(0);
>                      if (vlanId == null) {
>                          vlanId = vlan.getVlanTag();
>                      } else if (!NetUtils.isSameIsolationId(vlan.getVlanTag(), vlanId))
{
>                          throw new InvalidParameterValueException("there is already one
vlan " + vlan.getVlanTag()
> 
> starts throwing exception.
> 
> Fix includes additional check for the modified vlanid.
> The same checks are in NetUtils.isSameIsolationId() for checking untagged.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java d2e5aaa 
> 
> Diff: https://reviews.apache.org/r/18683/diff/
> 
> 
> Testing
> -------
> 
> Adding new guest IP range passes smoothly.
> Adding new public IP ranges passes smoothly.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message