cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 18568: Fix for returning null when expected is boolean; comparing objects with == instead of equals()
Date Mon, 03 Mar 2014 06:58:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18568/#review35946
-----------------------------------------------------------

Ship it!


9045e41483dcedfb57a9b8087bddb5115e9b8a6f

- daan Hoogland


On Feb. 27, 2014, 8:03 a.m., Wilder Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18568/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2014, 8:03 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix for Find Bugs findings on troubling issues: returning null when expected is boolean;
adding 6 unit tests and fix 1 in the KVMFencer; comparing objects with == instead of equals()
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/ha/XenServerFencer.java 28cba2b 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
48ae3ea 
>   plugins/hypervisors/xen/test/com/cloud/ha/XenServerFencerTest.java bd1d8f8 
>   server/src/com/cloud/ha/KVMFencer.java 516a579 
>   server/test/com/cloud/ha/KVMFencerTest.java cdd13b6 
> 
> Diff: https://reviews.apache.org/r/18568/diff/
> 
> 
> Testing
> -------
> 
> Added 6 unit tests for XenServerFencer (removed an useless one which was testing get/set
methods)
> Build completed successfully
> 
> Tested also on DevCloud + XenServer the following:
> 
> Create Zone + Network + Pod + cluster + Pri/Sec Storage + Console Proxy and System VMS
> Create 1 instance (tiny Linux) + Guest Network + 1 SourceNAT + 1 extra pub ip
> Set up firewall for port 22 + ICMP + port forwarding 22 ==> instance
> SSH into the instance
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message