cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebastien Goasguen" <run...@gmail.com>
Subject Re: Review Request 18516: CLOUDSTACK-6015: add apache license headers, add a new test: navigation test and related code.
Date Sun, 02 Mar 2014 18:38:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18516/#review35918
-----------------------------------------------------------


Yichi, can you make sure to set your name and email in your .gitconfig with:
$ git config --global user.name "Your Name"
$ git config --global user.email you@domain.com

That way we can have proper ownership of the patch.

If you can set those and re-submit the patch that would be best.

thanks

- Sebastien Goasguen


On Feb. 26, 2014, 3:27 p.m., Yichi Lu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18516/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2014, 3:27 p.m.)
> 
> 
> Review request for cloudstack, Nitin Mehta, Parth Jagirdar, and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> add apache license headers to all files. add a new test: navigation_test.py.
> 
> The tests were done against the 4.4.0 commit: 5c8bd6657323c7ea27b06777fb9e1b87a0af5680
> 
> 
> Diffs
> -----
> 
>   test/selenium/browser/__init__.py e69de29 
>   test/selenium/browser/firefox.py PRE-CREATION 
>   test/selenium/browser/firefox.py PRE-CREATION 
>   test/selenium/common/Global_Locators.py PRE-CREATION 
>   test/selenium/common/Global_Locators.py PRE-CREATION 
>   test/selenium/common/__init__.py e69de29 
>   test/selenium/common/shared.py PRE-CREATION 
>   test/selenium/common/shared.py PRE-CREATION 
>   test/selenium/cspages/__init__.py e69de29 
>   test/selenium/cspages/dashboard/__init__.py PRE-CREATION 
>   test/selenium/cspages/dashboard/dashboardpage.py PRE-CREATION 
>   test/selenium/cspages/login/__init__.py PRE-CREATION 
>   test/selenium/cspages/login/loginpage.py PRE-CREATION 
>   test/selenium/cspages/login/loginpage.py 39e4295 
>   test/selenium/cspages/loginpage.py PRE-CREATION 
>   test/selenium/cspages/loginpage.py PRE-CREATION 
>   test/selenium/cstests/__init__.py e69de29 
>   test/selenium/cstests/regressiontests/__init__.py PRE-CREATION 
>   test/selenium/cstests/smoketests/__init__.py e69de29 
>   test/selenium/cstests/smoketests/global_settings_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/login_logout_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/login_logout_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/login_logout_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/navigation_test.py PRE-CREATION 
>   test/selenium/cstests/smoketests/smokecfg.py PRE-CREATION 
>   test/selenium/cstests/smoketests/smokecfg.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18516/diff/
> 
> 
> Testing
> -------
> 
> USLT-205731:selenium yichi.lu$ python cstests/smoketests/login_logout_test.py 
> .........
> ----------------------------------------------------------------------
> Ran 9 tests in 219.643s
> 
> OK
> USLT-205731:selenium yichi.lu$ python cstests/smoketests/navigation_test.py 
> .
> ----------------------------------------------------------------------
> Ran 1 test in 69.194s
> 
> OK
> 
> 
> Thanks,
> 
> Yichi Lu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message