Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6E35710848 for ; Wed, 26 Feb 2014 08:34:19 +0000 (UTC) Received: (qmail 64328 invoked by uid 500); 26 Feb 2014 08:34:18 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 64288 invoked by uid 500); 26 Feb 2014 08:34:17 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 64268 invoked by uid 99); 26 Feb 2014 08:34:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Feb 2014 08:34:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 66F631C008A; Wed, 26 Feb 2014 08:34:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6043348051438090374==" MIME-Version: 1.0 Subject: Re: Review Request 17995: Added fix for CLOUDSTACK - 6164 From: "Santhosh Edukulla" To: "Girish Shilamkar" Cc: "Santhosh Edukulla" , "cloudstack" Date: Wed, 26 Feb 2014 08:34:13 -0000 Message-ID: <20140226083413.1577.20094@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Santhosh Edukulla" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17995/ X-Sender: "Santhosh Edukulla" References: <20140224150611.21193.8948@reviews.apache.org> In-Reply-To: <20140224150611.21193.8948@reviews.apache.org> Reply-To: "Santhosh Edukulla" X-ReviewRequest-Repository: cloudstack-git --===============6043348051438090374== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17995/ ----------------------------------------------------------- (Updated Feb. 26, 2014, 8:34 a.m.) Review request for cloudstack and Girish Shilamkar. Changes ------- Adding the correct patch file. Bugs: CLOUDSTACK-6164 https://issues.apache.org/jira/browse/CLOUDSTACK-6164 Repository: cloudstack-git Description ------- Currently,Host class has a create method, uses addHost Command, but 1. It does not verify the output of addHost command is valid output in all forms. 2. Tests some times directly goes to using Host post Host.create, but we are not sure whether the host is up or not, they have to explicitly call again listHosts api call, so every where host is added list host is called. Instead, the create method now returns the FAILED or host object based upon the api success and whether the host is up. 3. Added a try\except block and return FAILED to tests in case of an exception. Diffs ----- tools/marvin/marvin/config/test_data.py PRE-CREATION tools/marvin/marvin/deployDataCenter.py c8feaaf Diff: https://reviews.apache.org/r/17995/diff/ Testing ------- Tested indentation and import changes. File Attachments (updated) ---------------- Attached wrong file. Adding correct file https://reviews.apache.org/media/uploaded/files/2014/02/26/ca183e80-434c-4750-876c-fb4b6a377201__0001-Added-fix-for-CLOUDSTACK-6164.patch Thanks, Santhosh Edukulla --===============6043348051438090374==--