Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6BDE310845 for ; Tue, 25 Feb 2014 18:26:05 +0000 (UTC) Received: (qmail 13911 invoked by uid 500); 25 Feb 2014 18:26:04 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 13876 invoked by uid 500); 25 Feb 2014 18:26:04 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 13864 invoked by uid 99); 25 Feb 2014 18:26:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2014 18:26:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8B1B31C00EE; Tue, 25 Feb 2014 18:25:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5888112323095723272==" MIME-Version: 1.0 Subject: Re: Review Request 18358: NetUtils unit testing From: "Laszlo Hornyak" To: "daan Hoogland" , "Hugo Trippaers" Cc: "Miguel Ferreira" , "Laszlo Hornyak" , "cloudstack" Date: Tue, 25 Feb 2014 18:25:50 -0000 Message-ID: <20140225182550.30920.75753@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Laszlo Hornyak" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/18358/ X-Sender: "Laszlo Hornyak" References: <20140222134134.29670.67730@reviews.apache.org> In-Reply-To: <20140222134134.29670.67730@reviews.apache.org> Reply-To: "Laszlo Hornyak" X-ReviewRequest-Repository: cloudstack-git --===============5888112323095723272== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18358/#review35430 ----------------------------------------------------------- Ship it! Ship It! - Laszlo Hornyak On Feb. 22, 2014, 1:41 p.m., Miguel Ferreira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18358/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2014, 1:41 p.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > - Refactor tests: > - Upgrade tests to use jUnit4 > - Break big tests in small unit tests > - Replace assertTrue/False with complex conditions by assertThat with > specific matchers > - Remove dead code: > - Private static method never called locally > - Add test for method that validates CIDRs > > > Diffs > ----- > > pom.xml 1e9e8d8 > utils/src/com/cloud/utils/net/NetUtils.java c22e39a > utils/test/com/cloud/utils/net/NetUtilsTest.java d3e283c > > Diff: https://reviews.apache.org/r/18358/diff/ > > > Testing > ------- > > Ran all the tests in the test class before and after refactoring. > > > Thanks, > > Miguel Ferreira > > --===============5888112323095723272==--