Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9818110097 for ; Sun, 23 Feb 2014 15:23:49 +0000 (UTC) Received: (qmail 66568 invoked by uid 500); 23 Feb 2014 15:23:48 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 66534 invoked by uid 500); 23 Feb 2014 15:23:47 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 66524 invoked by uid 99); 23 Feb 2014 15:23:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Feb 2014 15:23:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7EB881C02A7; Sun, 23 Feb 2014 15:23:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3720225317249995575==" MIME-Version: 1.0 Subject: Re: Review Request 15932: Add support for Primary Storage on Gluster using the libvirt backend From: "Niels de Vos" To: "Wido den Hollander" , "Niels de Vos" , "cloudstack" Date: Sun, 23 Feb 2014 15:23:46 -0000 Message-ID: <20140223152346.21193.97665@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Niels de Vos" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15932/ X-Sender: "Niels de Vos" References: <20140219133523.4367.65340@reviews.apache.org> In-Reply-To: <20140219133523.4367.65340@reviews.apache.org> Reply-To: "Niels de Vos" X-ReviewRequest-Repository: cloudstack-git --===============3720225317249995575== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 19, 2014, 2:35 p.m., Wido den Hollander wrote: > > It seems good to me. Applies cleanly to master and builds just fine. > > > > Code-wise it's simple but effective, should allow us to support Gluster. > > Wido den Hollander wrote: > I just merged it into master and pushed. > > So gluster is in master right now! Niels, can I ask you to test it all again? Just to make sure the code all works like you intended. > > Niels de Vos wrote: > Thanks Wido! > This seems to be working OK for me. Note that the UI modification (https://reviews.apache.org/r/15933/) have not been reviewed/merged yet. Without these, it's rather difficult for users to configure Primary Storage on Gluster. > > Also, I've got asked about the dependencies and configuration. I'll add that here for now, and I'll try figure out how to get it added to the documentation: > > In /etc/glusterfs/glusterd.vol, allow unprivileged ports to contact the 'management' volume to get the volume configuration: > > option rpc-auth-allow-insecure on > > After changing the glusterd.vol file, restart the glusterd service to apply the changes. > > Per volume, allow unprivileged ports to access the brick processes (glusterfsd): > > # gluster volume set server.allow-insecure on > # gluster volume stop > # gluster volume start > > Per volume make sure that the kvm user (uid=36) and kvm group (gid=36) can access the images on the volume: > > # gluster volume set storage.owner-uid 36 > # gluster volume set storage.owner-gid 36 > > Other dependencies: > * libvirt version 1.0.1 (gluster protocol/network disk support) > * qemu version 1.3 (gluster block backend support) > > Note that RHEL-6.5 and derived distributions contain backports that add sufficient functionality too. Some further testing showed that there can be some issues with starting virtual machines which have disks on Gluster. https://reviews.apache.org/r/18412/ contains a solution for that. - Niels ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15932/#review34859 ----------------------------------------------------------- On Feb. 19, 2014, 9:24 a.m., Niels de Vos wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15932/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 9:24 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > The support for Gluster as Primary Storage is mostly based on the > implementation for NFS. Like NFS, libvirt can address a Gluster environment > through the 'netfs' pool-type. > > > Diffs > ----- > > api/src/com/cloud/storage/Storage.java ff83dfc > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java d63b643 > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolDef.java dbe5d4b > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtStoragePoolXMLParser.java a6186f6 > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java ff75d61 > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java 8cdecd8 > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java a5f33eb > plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java b90d5fc > > Diff: https://reviews.apache.org/r/15932/diff/ > > > Testing > ------- > > See http://blog.nixpanic.net/2013/12/using-gluster-as-primary-storage-in.html > > > Thanks, > > Niels de Vos > > --===============3720225317249995575==--