Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 70B20107AE for ; Tue, 18 Feb 2014 16:09:18 +0000 (UTC) Received: (qmail 82590 invoked by uid 500); 18 Feb 2014 16:09:17 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 82187 invoked by uid 500); 18 Feb 2014 16:09:16 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 82167 invoked by uid 99); 18 Feb 2014 16:09:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 16:09:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6913B1C00F6; Tue, 18 Feb 2014 16:09:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7787125057134795952==" MIME-Version: 1.0 Subject: Re: Review Request 18213: Fix and add some Rest unit and IT tests. Remove duplication of site pugin declaration. Fix by adding a missing type of RoutingConfig. From: "Antonio Fornie" To: "daan Hoogland" , "Hugo Trippaers" Cc: "Antonio Fornie" , "cloudstack" Date: Tue, 18 Feb 2014 16:09:13 -0000 Message-ID: <20140218160913.4362.25743@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Antonio Fornie" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/18213/ X-Sender: "Antonio Fornie" References: <20140218134209.4362.7898@reviews.apache.org> In-Reply-To: <20140218134209.4362.7898@reviews.apache.org> Reply-To: "Antonio Fornie" X-ReviewRequest-Repository: cloudstack-git --===============7787125057134795952== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18213/ ----------------------------------------------------------- (Updated Feb. 18, 2014, 4:09 p.m.) Review request for cloudstack, daan Hoogland and Hugo Trippaers. Changes ------- Can you check that this time there is no collision with Hugo's change on root pom (removal of site plugin duplication)? Repository: cloudstack-git Description ------- Fix and add some Rest unit and IT tests. Remove duplication of site pugin declaration. Fix by adding a missing type of RoutingConfig. Diffs (updated) ----- plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 3861d63 plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/RoutingTableRoutingConfig.java PRE-CREATION plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java fe41545 utils/test/com/cloud/utils/rest/RESTServiceConnectorTest.java 17864b4 Diff: https://reviews.apache.org/r/18213/diff/ Testing ------- Full maven lifecycle with unit and integration tests. Execute most of the functionality against our Ncira server. Thanks, Antonio Fornie --===============7787125057134795952==--