Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 929BC10751 for ; Tue, 18 Feb 2014 08:52:35 +0000 (UTC) Received: (qmail 38517 invoked by uid 500); 18 Feb 2014 08:52:34 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 37845 invoked by uid 500); 18 Feb 2014 08:52:32 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 37833 invoked by uid 99); 18 Feb 2014 08:52:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Feb 2014 08:52:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4312D1C00F6; Tue, 18 Feb 2014 08:52:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3899899637636164528==" MIME-Version: 1.0 Subject: Re: Review Request 17638: Rest client moved to utils. Nvp extended. From: "Hugo Trippaers" To: "daan Hoogland" , "Hugo Trippaers" Cc: "Antonio Fornie" , "cloudstack" Date: Tue, 18 Feb 2014 08:52:30 -0000 Message-ID: <20140218085230.4367.84392@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Hugo Trippaers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17638/ X-Sender: "Hugo Trippaers" References: <20140206125322.17020.33540@reviews.apache.org> In-Reply-To: <20140206125322.17020.33540@reviews.apache.org> Reply-To: "Hugo Trippaers" X-ReviewRequest-Repository: cloudstack-git --===============3899899637636164528== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17638/#review34684 ----------------------------------------------------------- Ship it! commit 510972abde3b5435ed2a4d02fc4f59a1f6dabefe Author: Antonio Fornie Date: Wed Feb 5 10:01:06 2014 +0100 Nvp and rest refactoring and more tests Signed-off-by: Hugo Trippaers - Hugo Trippaers On Feb. 6, 2014, 12:53 p.m., Antonio Fornie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17638/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 12:53 p.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Rest client moved to utils in a generic way so it can be reused (from opendaylight, for example). Incremented integration tests. Also include cobertura and it-cobertura. Nvp extended with a few methods missing. > > > Diffs > ----- > > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/AccessConfiguration.java 487f14b > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/Acl.java 976177f > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/BaseNiciraEntity.java PRE-CREATION > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/BaseNiciraNamedEntity.java PRE-CREATION > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouter.java PRE-CREATION > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterConfig.java b6eaa8f > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalRouterPort.java 8ffe054 > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitch.java 2379354 > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java 3565fbe > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 83d0075 > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplicitRoutingConfig.java PRE-CREATION > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/SingleDefaultRouteImplictRoutingConfig.java 0533579 > plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/VifAttachment.java 87765be > plugins/network-elements/nicira-nvp/src/com/cloud/network/resource/NiciraNvpResource.java c228b08 > plugins/network-elements/nicira-nvp/test/com/cloud/network/element/NiciraNvpElementTest.java 822c8c7 > plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java db8637c > plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NatRuleTest.java 84b28fb > plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiIT.java 7f8f471 > plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraNvpApiTest.java 13d970c > plugins/network-elements/nicira-nvp/test/com/cloud/network/nicira/NiciraTagTest.java 58dcedc > plugins/network-elements/nicira-nvp/test/com/cloud/network/resource/NiciraNvpResourceTest.java 2717c31 > pom.xml 1d2304f > utils/pom.xml f63d7c4 > utils/src/com/cloud/utils/rest/BasicEncodedRESTValidationStrategy.java PRE-CREATION > utils/src/com/cloud/utils/rest/CloudstackRESTException.java PRE-CREATION > utils/src/com/cloud/utils/rest/RESTServiceConnector.java PRE-CREATION > utils/src/com/cloud/utils/rest/RESTValidationStrategy.java PRE-CREATION > utils/test/com/cloud/utils/rest/RESTServiceConnectorTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/17638/diff/ > > > Testing > ------- > > mvn full build plus unit and integration tests > > > Thanks, > > Antonio Fornie > > --===============3899899637636164528==--