Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 33AD5100AC for ; Fri, 14 Feb 2014 10:45:38 +0000 (UTC) Received: (qmail 87697 invoked by uid 500); 14 Feb 2014 10:45:38 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 86918 invoked by uid 500); 14 Feb 2014 10:45:33 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 86898 invoked by uid 99); 14 Feb 2014 10:45:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Feb 2014 10:45:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E72D51C0429; Fri, 14 Feb 2014 10:45:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4102033920911661053==" MIME-Version: 1.0 Subject: Re: Review Request 17702: CLOUDSTACK-2232: Adding automation test cases for Persistent Networks feature From: "Ashutosh Kelkar" To: "Girish Shilamkar" , "Santhosh Edukulla" Cc: "Ashutosh Kelkar" , "cloudstack" Date: Fri, 14 Feb 2014 10:45:27 -0000 Message-ID: <20140214104527.29299.38502@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ashutosh Kelkar" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17702/ X-Sender: "Ashutosh Kelkar" References: <20140212172344.12058.55414@reviews.apache.org> In-Reply-To: <20140212172344.12058.55414@reviews.apache.org> Reply-To: "Ashutosh Kelkar" X-ReviewRequest-Repository: cloudstack-git --===============4102033920911661053== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 12, 2014, 5:23 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_persistent_networks.py, line 1336 > > > > > > Is waiting required post disable\lock? or after Account.list? Yes, because we have to check the "persistent" property of network, for that we will have to wait for cleanup interval post the lock/disable action. We will not catch the bug if we don't wait, because network won't get cleaned up immediately. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17702/#review34292 ----------------------------------------------------------- On Feb. 14, 2014, 10:38 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17702/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 10:38 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-2232 > https://issues.apache.org/jira/browse/CLOUDSTACK-2232 > > > Repository: cloudstack-git > > > Description > ------- > > Adding automation test cases for Persistent Networks feature. > > > Diffs > ----- > > test/integration/component/test_persistent_networks.py f61ccaa > tools/marvin/marvin/config/config.cfg 7840b7c > tools/marvin/marvin/integration/lib/base.py aa23029 > tools/marvin/marvin/integration/lib/common.py e202391 > > Diff: https://reviews.apache.org/r/17702/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > > --===============4102033920911661053==--