Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 26E9410E40 for ; Fri, 14 Feb 2014 09:12:45 +0000 (UTC) Received: (qmail 54597 invoked by uid 500); 14 Feb 2014 09:12:44 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 54549 invoked by uid 500); 14 Feb 2014 09:12:43 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 54537 invoked by uid 99); 14 Feb 2014 09:12:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Feb 2014 09:12:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1EB4D1C0429; Fri, 14 Feb 2014 09:12:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8959690477482047595==" MIME-Version: 1.0 Subject: Re: Review Request 18069: Fixing FindBugs scariest for replaceFirst() method call that does not assign the return value From: "Hugo Trippaers" To: "daan Hoogland" , "Hugo Trippaers" Cc: "Wilder Rodrigues" , "cloudstack" Date: Fri, 14 Feb 2014 09:12:41 -0000 Message-ID: <20140214091241.29299.8657@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Hugo Trippaers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/18069/ X-Sender: "Hugo Trippaers" References: <20140213120734.1632.1290@reviews.apache.org> In-Reply-To: <20140213120734.1632.1290@reviews.apache.org> Reply-To: "Hugo Trippaers" X-ReviewRequest-Repository: cloudstack-git --===============8959690477482047595== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18069/#review34469 ----------------------------------------------------------- Ship it! commit 8c5886ee7fadcab11834f9e514cf05925f67fc33 Author: wrodrigues Date: Mon Feb 10 15:13:56 2014 +0100 fixing FindBugs scariest for replaceFirst() method call that does not assign the return value Signed-off-by: Hugo Trippaers - Hugo Trippaers On Feb. 13, 2014, 12:07 p.m., Wilder Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18069/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 12:07 p.m.) > > > Review request for cloudstack, daan Hoogland and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Fixing FindBugs scariest for replaceFirst() method call that does not assign the return value > > > Diffs > ----- > > plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 37861b4 > plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/provider/CloudStackPrimaryDataStoreProviderImpl.java 410416c > > Diff: https://reviews.apache.org/r/18069/diff/ > > > Testing > ------- > > Build ran successfully > > > Thanks, > > Wilder Rodrigues > > --===============8959690477482047595==--