Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============4821872384058462355=="
MIME-Version: 1.0
Subject: Re: Review Request 17847: CLOUDSTACK-5978: Changes in get_template
 function
 to make it independent of ostype passed through test case
From: "Girish Shilamkar" <girish@clogeny.com>
To: "Girish Shilamkar" <girish@clogeny.com>
Cc: "Ashutosh Kelkar" <ashutosh@clogeny.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Mon, 10 Feb 2014 07:11:07 -0000
Message-ID: <20140210071107.23313.90231@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Girish Shilamkar" <noreply@reviews.apache.org>
References: <20140207135908.2770.1834@reviews.apache.org>
In-Reply-To: <20140207135908.2770.1834@reviews.apache.org>
Reply-To: "Girish Shilamkar" <girish@clogeny.com>

--===============4821872384058462355==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17847/#review34055
-----------------------------------------------------------


Committed to 4.3-forward and master

- Girish Shilamkar


On Feb. 7, 2014, 1:59 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17847/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2014, 1:59 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-5978
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5978
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Some test cases are failing because the ostype passed to the get_template function is different in each test case and it fails whenever it does not match with the ostype of template in the CS setup. Changed get_template function so that ostype id does not have any effect on the returning data (It will always return the feature, built in template in the given zone which is in READY state). This way we eliminate the dependency between the test case and the CS setup.
> 
> This is the first set of change in marvin library. In next step, we can remove the hard coded ostype from all the test cases. For now, this is sufficient to save test cases from failing due to hard coded value.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/integration/lib/common.py 550de1a 
> 
> Diff: https://reviews.apache.org/r/17847/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


--===============4821872384058462355==--