Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A286B1011F for ; Mon, 10 Feb 2014 05:56:33 +0000 (UTC) Received: (qmail 28165 invoked by uid 500); 10 Feb 2014 05:56:32 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 27975 invoked by uid 500); 10 Feb 2014 05:56:31 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 27952 invoked by uid 99); 10 Feb 2014 05:56:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Feb 2014 05:56:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 89BF91D4874; Mon, 10 Feb 2014 05:56:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9198382917318050428==" MIME-Version: 1.0 Subject: Re: Review Request 17842: fixed vmsync for hyperv From: "Devdeep Singh" To: "Rajesh Battala" , "Devdeep Singh" Cc: "Anshul Gangwar" , "cloudstack" Date: Mon, 10 Feb 2014 05:56:28 -0000 Message-ID: <20140210055628.23313.34378@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Devdeep Singh" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17842/ X-Sender: "Devdeep Singh" References: <20140207112204.17020.67622@reviews.apache.org> In-Reply-To: <20140207112204.17020.67622@reviews.apache.org> Reply-To: "Devdeep Singh" X-ReviewRequest-Repository: cloudstack-git --===============9198382917318050428== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17842/#review34046 ----------------------------------------------------------- plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs There is already a WmiCallsV2::EnabledState class defined. Please use that. plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java Hyperv agent should map the hyper-v state to cloudstack state and return an appropriate state in the answer. Lookat WmiCallsV2::EnabledState.ToCloudStackState - Devdeep Singh On Feb. 7, 2014, 11:22 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17842/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 11:22 a.m.) > > > Review request for cloudstack, Devdeep Singh and Rajesh Battala. > > > Bugs: CLOUDSTACK-6054 > https://issues.apache.org/jira/browse/CLOUDSTACK-6054 > > > Repository: cloudstack-git > > > Description > ------- > > fixed vmsync for hyperv. This fix adds an api call which return the hostvmstatereport and made appropriate changes to HypervDirectConnectResource.java > > > Diffs > ----- > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 9637994 > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs a132606 > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/IWmiCallsV2.cs 5f814c5 > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs f5a04dc > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java a4dca6a > > Diff: https://reviews.apache.org/r/17842/diff/ > > > Testing > ------- > > Performed basic vm operations externally and verifying their state got updated correctly in cloudstack > > > Thanks, > > Anshul Gangwar > > --===============9198382917318050428==--