Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4E53C10F4F for ; Fri, 7 Feb 2014 10:56:56 +0000 (UTC) Received: (qmail 65213 invoked by uid 500); 7 Feb 2014 10:56:54 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 64995 invoked by uid 500); 7 Feb 2014 10:56:53 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 64985 invoked by uid 99); 7 Feb 2014 10:56:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Feb 2014 10:56:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 308741C03EC; Fri, 7 Feb 2014 10:56:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1025318791071177522==" MIME-Version: 1.0 Subject: Review Request 17841: CLOUDSTACK-5959: Fixed cascading failures in portable IP test cases From: "Gaurav Aradhye" To: "Girish Shilamkar" Cc: "Gaurav Aradhye" , "cloudstack" Date: Fri, 07 Feb 2014 10:56:52 -0000 Message-ID: <20140207105652.2770.8549@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gaurav Aradhye" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17841/ X-Sender: "Gaurav Aradhye" Reply-To: "Gaurav Aradhye" X-ReviewRequest-Repository: cloudstack-git --===============1025318791071177522== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17841/ ----------------------------------------------------------- Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5959 https://issues.apache.org/jira/browse/CLOUDSTACK-5959 Repository: cloudstack-git Description ------- Failure in firewall creation is leading to incomplete cleanup and eventually cascading failure of the test cases. Made changes so that even in case of failure in one test case, other test cases are not affected and cleanup is performed gracefully. Also did 1) Code cleanup 2) Modifying imports 3) Adding FS and test plan links 4) Refactoring code Diffs ----- test/integration/component/test_portable_ip.py d397ec4 tools/marvin/marvin/integration/lib/common.py 550de1a Diff: https://reviews.apache.org/r/17841/diff/ Testing ------- Tested on VMware Thanks, Gaurav Aradhye --===============1025318791071177522==--