Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7AAE010E9E for ; Thu, 6 Feb 2014 14:07:07 +0000 (UTC) Received: (qmail 88051 invoked by uid 500); 6 Feb 2014 14:07:06 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 87625 invoked by uid 500); 6 Feb 2014 14:06:57 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 87610 invoked by uid 99); 6 Feb 2014 14:06:53 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Feb 2014 14:06:53 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C34DE1D4794; Thu, 6 Feb 2014 14:06:52 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0076802982680162751==" MIME-Version: 1.0 Subject: Review Request 17789: method to handle default template changes From: "suresh sadhu" To: "Santhosh Edukulla" , "SrikanteswaraRao Talluri" Cc: "suresh sadhu" , "cloudstack" Date: Thu, 06 Feb 2014 14:06:52 -0000 Message-ID: <20140206140652.17020.29148@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "suresh sadhu" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17789/ X-Sender: "suresh sadhu" Reply-To: "suresh sadhu" X-ReviewRequest-Repository: cloudstack-git --===============0076802982680162751== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17789/ ----------------------------------------------------------- Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. Bugs: cloudstack-6042 https://issues.apache.org/jira/browse/cloudstack-6042 Repository: cloudstack-git Description ------- Right now default template for xen changed and test scripts are still point to old template ,due to this deployvm and other scripts are failing and its hard coded in each script. So I wrote a method to return built-in OS name dynamically. but here we need to add one line of code in each script another solution is : we have get_template method and again this is depend on hardcoded parameter type ostype.this is generic method . ,if modify exiting logic little bit(it won't be generic and specific to built-in template)then no need to touch other scripts. Please review and share you input Diffs ----- tools/marvin/marvin/integration/lib/common.py 550de1a Diff: https://reviews.apache.org/r/17789/diff/ Testing ------- yes Thanks, suresh sadhu --===============0076802982680162751==--