Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 91C5310263 for ; Thu, 6 Feb 2014 09:33:39 +0000 (UTC) Received: (qmail 84237 invoked by uid 500); 6 Feb 2014 09:33:38 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 83924 invoked by uid 500); 6 Feb 2014 09:33:38 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 83909 invoked by uid 99); 6 Feb 2014 09:33:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Feb 2014 09:33:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E10A41D478A; Thu, 6 Feb 2014 09:33:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7380240082396976356==" MIME-Version: 1.0 Subject: Re: Review Request 17748: Solve fixBugs finding From: "daan Hoogland" To: "daan Hoogland" Cc: "Ian Southam" , "cloudstack" Date: Thu, 06 Feb 2014 09:33:34 -0000 Message-ID: <20140206093334.1219.5269@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "daan Hoogland" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17748/ X-Sender: "daan Hoogland" References: <20140205174556.3575.97206@reviews.apache.org> In-Reply-To: <20140205174556.3575.97206@reviews.apache.org> Reply-To: "daan Hoogland" X-ReviewRequest-Repository: cloudstack-git --===============7380240082396976356== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17748/#review33782 ----------------------------------------------------------- Ship it! cecb216caa22541d243369e76ef80b4f2225b728 - daan Hoogland On Feb. 5, 2014, 5:45 p.m., Ian Southam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17748/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 5:45 p.m.) > > > Review request for cloudstack and daan Hoogland. > > > Repository: cloudstack-git > > > Description > ------- > > fixBugs raised this as a scariest category bug. > > Equals is breaking its contract by comparing (potentially) unequal objects. > > (In the end, The helper class is referenced in spring and being used) > > > Diffs > ----- > > engine/storage/src/org/apache/cloudstack/storage/image/format/ImageFormatHelper.java 9523d24 > > Diff: https://reviews.apache.org/r/17748/diff/ > > > Testing > ------- > > > Thanks, > > Ian Southam > > --===============7380240082396976356==--