Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8B02D100F3 for ; Wed, 5 Feb 2014 23:23:05 +0000 (UTC) Received: (qmail 311 invoked by uid 500); 5 Feb 2014 23:23:04 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 238 invoked by uid 500); 5 Feb 2014 23:23:04 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 227 invoked by uid 99); 5 Feb 2014 23:23:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2014 23:23:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ACB6F1D47A9; Wed, 5 Feb 2014 23:23:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1333090946431423440==" MIME-Version: 1.0 Subject: Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class. From: "Sachchidanand Vaidya" To: "daan Hoogland" , "Sachchidanand Vaidya" , "cloudstack" Date: Wed, 05 Feb 2014 23:23:03 -0000 Message-ID: <20140205232303.1219.80014@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sachchidanand Vaidya" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16523/ X-Sender: "Sachchidanand Vaidya" References: <20140203221526.14639.60107@reviews.apache.org> In-Reply-To: <20140203221526.14639.60107@reviews.apache.org> Reply-To: "Sachchidanand Vaidya" X-ReviewRequest-Repository: cloudstack-git --===============1333090946431423440== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16523/ ----------------------------------------------------------- (Updated Feb. 5, 2014, 11:23 p.m.) Review request for cloudstack. Changes ------- Hi Daan, I have updated files correcting some of the formatting. Pls let me know if this looks ok. Thanks, Sachin Repository: cloudstack-git Description ------- Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class. Diffs (updated) ----- plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION Diff: https://reviews.apache.org/r/16523/diff/ Testing ------- All Juniper contrail plugin unit tests pass without any error. Thanks, Sachchidanand Vaidya --===============1333090946431423440==--