Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4EBEA108E4 for ; Tue, 4 Feb 2014 13:12:34 +0000 (UTC) Received: (qmail 76076 invoked by uid 500); 4 Feb 2014 13:12:30 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 75915 invoked by uid 500); 4 Feb 2014 13:12:27 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 75901 invoked by uid 99); 4 Feb 2014 13:12:26 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 13:12:26 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 31CCE1D4747; Tue, 4 Feb 2014 13:12:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8960156641138503628==" MIME-Version: 1.0 Subject: Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class. From: "daan Hoogland" To: "daan Hoogland" , "Sachchidanand Vaidya" , "cloudstack" Date: Tue, 04 Feb 2014 13:12:25 -0000 Message-ID: <20140204131225.14639.91723@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "daan Hoogland" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/16523/ X-Sender: "daan Hoogland" References: <20140203221526.14639.60107@reviews.apache.org> In-Reply-To: <20140203221526.14639.60107@reviews.apache.org> Reply-To: "daan Hoogland" X-ReviewRequest-Repository: cloudstack-git --===============8960156641138503628== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16523/#review33581 ----------------------------------------------------------- sorry to bug you again but the tests give checkstyle errors. Can you fix these and resubmit? - daan Hoogland On Feb. 3, 2014, 10:15 p.m., Sachchidanand Vaidya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16523/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 10:15 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class. > > > Diffs > ----- > > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION > plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/16523/diff/ > > > Testing > ------- > > All Juniper contrail plugin unit tests pass without any error. > > > Thanks, > > Sachchidanand Vaidya > > --===============8960156641138503628==--