Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 486EA10679 for ; Tue, 4 Feb 2014 11:33:46 +0000 (UTC) Received: (qmail 21759 invoked by uid 500); 4 Feb 2014 11:33:45 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 20983 invoked by uid 500); 4 Feb 2014 11:33:40 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 20971 invoked by uid 99); 4 Feb 2014 11:33:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 11:33:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0FDA71D4747; Tue, 4 Feb 2014 11:33:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6517267488381694816==" MIME-Version: 1.0 Subject: Review Request 17703: base.py fix for Dynamic compute offerings , added a new test case for custom compute offerings From: "prashant mishra" To: "Santhosh Edukulla" , "sanjeev n" , "SrikanteswaraRao Talluri" Cc: "prashant mishra" , "cloudstack" Date: Tue, 04 Feb 2014 11:33:37 -0000 Message-ID: <20140204113337.3575.43244@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "prashant mishra" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17703/ X-Sender: "prashant mishra" Reply-To: "prashant mishra" X-ReviewRequest-Repository: cloudstack-git --===============6517267488381694816== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17703/ ----------------------------------------------------------- Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5951 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5951 Repository: cloudstack-git Description ------- with dynamic computer offering feature service offering can be created without cpunumber,cpuspeed , memory and these values can be provided at time of vm deployment issue in base.py: cpuspeed,cpunumber,memory is compulsory to create SO and these values cant be passed in deployVirtualMachine API. Fix: cpuspeed, cpunumber,memory will be optional parameter, and these values can be passed in deployVirtualMachine API. Diffs ----- test_custom_compute_offering.py PRE-CREATION tools/marvin/marvin/lib/base.py aa23029 Diff: https://reviews.apache.org/r/17703/diff/ Testing ------- Tested vm deployment with regular computer offering and custom compute offerings Thanks, prashant mishra --===============6517267488381694816==--