Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 814EB10440 for ; Tue, 4 Feb 2014 10:18:09 +0000 (UTC) Received: (qmail 96564 invoked by uid 500); 4 Feb 2014 10:18:09 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 95788 invoked by uid 500); 4 Feb 2014 10:18:07 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 95775 invoked by uid 99); 4 Feb 2014 10:18:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2014 10:18:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1A7E91D45D6; Tue, 4 Feb 2014 10:18:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8944988661910708453==" MIME-Version: 1.0 Subject: Re: Review Request 17658: Added Few changes for CLOUDSTACK-5980 From: "ASF Subversion and Git Services" To: "Girish Shilamkar" Cc: "Santhosh Edukulla" , "ASF Subversion and Git Services" , "cloudstack" Date: Tue, 04 Feb 2014 10:18:03 -0000 Message-ID: <20140204101803.14639.59106@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/17658/ X-Sender: "ASF Subversion and Git Services" References: <20140203130502.14639.99054@reviews.apache.org> In-Reply-To: <20140203130502.14639.99054@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============8944988661910708453== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17658/#review33577 ----------------------------------------------------------- Commit 286afda5d687b167691c17bf15aaf55738953383 in branch refs/heads/marvin from Santhosh Edukulla [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=286afda ] CLOUDSTACK-5980: Fix test case failing with "Error reading SSH protocol banner" ssh error - ASF Subversion and Git Services On Feb. 3, 2014, 1:05 p.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17658/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 1:05 p.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-5980 > https://issues.apache.org/jira/browse/CLOUDSTACK-5980 > > > Repository: cloudstack-git > > > Description > ------- > > 1. Added a timeout flag to execute.. command under sshClient > 2. Added a break in finally for createConnection,when command is successful, earlier it was running despite that > 3. Added load.. call when key_pair files are passed. > 4. Cleaned up few things under cloudstackConnection. > > Please apply it on marvin branch. > > > Diffs > ----- > > tools/marvin/marvin/cloudstackConnection.py 8413ac0 > tools/marvin/marvin/sshClient.py 09dc6f3 > > Diff: https://reviews.apache.org/r/17658/diff/ > > > Testing > ------- > > Ran pep8 and more tests as part of marvin branch will be run. > > > Thanks, > > Santhosh Edukulla > > --===============8944988661910708453==--