Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 94E6210549 for ; Mon, 3 Feb 2014 00:24:54 +0000 (UTC) Received: (qmail 3459 invoked by uid 500); 3 Feb 2014 00:24:53 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 3380 invoked by uid 500); 3 Feb 2014 00:24:53 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 3368 invoked by uid 99); 3 Feb 2014 00:24:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Feb 2014 00:24:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 551581C02BB; Mon, 3 Feb 2014 00:24:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8305696402462127211==" MIME-Version: 1.0 Subject: Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled From: "ASF Subversion and Git Services" To: "daan Hoogland" Cc: "ASF Subversion and Git Services" , "David Grizzanti" , "Dennis John" , "cloudstack" Date: Mon, 03 Feb 2014 00:24:50 -0000 Message-ID: <20140203002450.14639.36731@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/15280/ X-Sender: "ASF Subversion and Git Services" References: <20140122140940.11320.94805@reviews.apache.org> In-Reply-To: <20140122140940.11320.94805@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============8305696402462127211== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15280/#review33403 ----------------------------------------------------------- Commit 91ec548fc0b08aa4ff8e6aa57fab013ab9892893 in branch refs/heads/4.3 from David Grizzanti [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=91ec548 ] CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled Signed-off-by: Daan Hoogland (cherry picked from commit 62a259ffa9b4daabcbe4f9afe9a78eadebbb7bff) Signed-off-by: Animesh Chaturvedi - ASF Subversion and Git Services On Jan. 22, 2014, 2:09 p.m., David Grizzanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15280/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 2:09 p.m.) > > > Review request for cloudstack and daan Hoogland. > > > Bugs: CLOUDSTACK-5062 > https://issues.apache.org/jira/browse/CLOUDSTACK-5062 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled > > Added logic so that a correct zoneID is passed when generating usage events while deleting load balancing rules: > - Added logic to server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to grab zone id and pass to publishUsageEvent > > > Diffs > ----- > > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java be81a3e > > Diff: https://reviews.apache.org/r/15280/diff/ > > > Testing > ------- > > Testing only on 4.2 > > > Thanks, > > David Grizzanti > > --===============8305696402462127211==--