cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sheng Yang <sh...@yasker.org>
Subject Master blocker CLOUDSTACK-6130
Date Thu, 20 Feb 2014 04:50:05 GMT
Hi Hugo/Ian,

I suspect https://issues.apache.org/jira/browse/CLOUDSTACK-6130 is caused
by some of recent change of findbugs. It's likely got something wrong with
GeneralDaoBase, and the most recently modifications are:

commit 443acac92792cbffff2654c3414df276efac404f
Author: Hugo Trippaers <htrippaers@schubergphilis.com>
Date:   Fri Feb 14 18:36:18 2014 +0100

    Fix functional issue introduced by some findbug changes.

commit 5a6ad11fa2ca3de64b94095c628bd3ba12e618c3
Author: Ian Southam <isoutham@schubergphilis.com>
Date:   Wed Feb 12 17:08:52 2014 +0100

    findbugs findings

    Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>

>From the error message, it shows statement as:

SELECT COUNT(*) FROM user_ip_address INNER JOIN account ON
user_ip_address.account_id=account.id INNER JOIN vlan ON
user_ip_address.vlan_db_id=vlan.id WHERE user_ip_address.account_id=5 AND
user_ip_address.allocated IS NOT NULL AND (account.type != 'VirtualNetwork'
) AND (vlan.vlan_type = ** NOT SPECIFIED ** )

And you can observed that some parameters have been shifted left by one
position, because vlan.vlan_type should compare to "virtualNetwork". It
should related to "i++"/"++i" change in the commit.

After reverting these two commits, everything is fine.

Could you take a look?

--Sheng

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message