cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rajani Karuturi <Rajani.Karut...@citrix.com>
Subject Re: Findbugs report on 4.3-forward
Date Mon, 03 Feb 2014 06:55:56 GMT
Hi Daan/Ian,
looks like the change is only in 4.3. Can you please do it on 4.3-forward and master as well.


Thanks,
~Rajani



On 03-Feb-2014, at 12:21 am, Daan Hoogland <daan.hoogland@gmail.com> wrote:

> just pushed :(
> 
> 
> On Sun, Feb 2, 2014 at 7:50 PM, Ian Duffy <ian@ianduffy.ie> wrote:
>> Daan,
>> 
>> Have this done already, just about to push.
>> 
>> 
>> On 2 February 2014 18:47, Daan Hoogland <daan.hoogland@gmail.com> wrote:
>> 
>>> never mind, I thought you are committer. I'll fix
>>> 
>>> On Sun, Feb 2, 2014 at 6:52 PM, Rajani Karuturi
>>> <Rajani.Karuturi@citrix.com> wrote:
>>>> Sure Daan. Will submit a review request for master and 4.3-forward
>>> tomorrow morning IST.
>>>> 
>>>> Thanks,
>>>> ~Rajani
>>>> 
>>>> 
>>>> 
>>>> On 02-Feb-2014, at 8:17 pm, Daan Hoogland <daan.hoogland@gmail.com>
>>> wrote:
>>>> 
>>>>> On Sun, Feb 2, 2014 at 12:48 PM, Rajani Karuturi
>>>>> <Rajani.Karuturi@citrix.com> wrote:
>>>>>> what we should use is new String(bytes[])
>>>>> 
>>>>> 
>>>>> ok, makes sense. Can you revert my commit and make a new patch?
>>>>> 
>>>>> thanks,
>>>>> Daan
>>>> 
>>> 
>>> 
>>> 
>>> --
>>> Daan
>>> 
> 
> 
> 
> -- 
> Daan


Mime
View raw message