cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: commit 6523c068695d0431070060667c222eb40d54b14d breaks network removal
Date Fri, 07 Feb 2014 08:23:18 GMT


> -----Original Message-----
> From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
> Sent: Thursday, February 06, 2014 9:56 PM
> To: Alena Prokharchyk
> Cc: dev@cloudstack.apache.org; eizadi@infoblox.com
> Subject: Re: commit 6523c068695d0431070060667c222eb40d54b14d breaks
> network removal
> 
> second thought,
> 
> Soheils mail bounces and the commit does not refer a ticket from jira.
> I am going to revert. I should have been more vigilant. sorry.
> 
[Animesh] Daan was this change introduced because of being flagged during findbug run? 

> On Fri, Feb 7, 2014 at 6:49 AM, Daan Hoogland <daan.hoogland@gmail.com>
> wrote:
> > will do Alena,
> >
> > thanks for the headsup
> >
> > On Thu, Feb 6, 2014 at 10:42 PM, Alena Prokharchyk
> > <Alena.Prokharchyk@citrix.com> wrote:
> >> Soheil/Daan,
> >>
> >> The commit in the subject breaks network System vms destroy (VR,
> >> SSVM, CPVM), resulting in the network removal failures. Following
> >> line replacement causes the failure:
> >>
> >> - if (vm.getType() == Type.User &&
> >> isDhcpAccrossMultipleSubnetsSupported(network) &&
> >> isLastNicInSubnet(nic) &&
> >> network.getTrafficType() == TrafficType.Guest
> >>
> >> With
> >>
> >> +        DhcpServiceProvider dhcpServiceProvider =
> >> getDhcpServiceProvider(network);
> >>
> >>
> >> When you try to call getDhcpServiceProvider(network), it throws an
> >> exception because DHCP service is not enabled in Public/Control
> >> networks of system vms nics. So system vm always fails to expunge.
> >>
> >> Could you please fix it by checking if DHCP service is enabled on the
> >> network, before getting the DHCP service provider?
> >>
> >> Thanks,
> >> Alena.
> >>
> >>
> >>
> >
> >
> >
> > --
> > Daan
> 
> 
> 
> --
> Daan

Mime
View raw message