cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Animesh Chaturvedi <animesh.chaturv...@citrix.com>
Subject RE: Review Request 15280: CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating usage events are enabled
Date Mon, 03 Feb 2014 00:52:00 GMT
Pulled this one into latest 4.3 too

> -----Original Message-----
> From: daan Hoogland [mailto:noreply@reviews.apache.org] On Behalf Of
> daan Hoogland
> Sent: Friday, January 31, 2014 2:27 AM
> To: daan Hoogland
> Cc: David Grizzanti; Dennis John; cloudstack
> Subject: Re: Review Request 15280: CLOUDSTACK-5062: Deleting Load
> Balancing Rule fails when generating usage events are enabled
> 
> 
> 
> > On Jan. 31, 2014, 10:20 a.m., daan Hoogland wrote:
> > > ported to master and committed:
> fc796632ed984f37fdf32e6aedf26d179a70b22f
> 
> 62a259ffa9b4daabcbe4f9afe9a78eadebbb7bff on 4.3-forward
> 
> 
> - daan
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15280/#review33308
> -----------------------------------------------------------
> 
> 
> On Jan. 22, 2014, 2:09 p.m., David Grizzanti wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/15280/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 22, 2014, 2:09 p.m.)
> >
> >
> > Review request for cloudstack and daan Hoogland.
> >
> >
> > Bugs: CLOUDSTACK-5062
> >     https://issues.apache.org/jira/browse/CLOUDSTACK-5062
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > CLOUDSTACK-5062: Deleting Load Balancing Rule fails when generating
> usage events are enabled
> >
> > Added logic so that a correct zoneID is passed when generating usage
> events while deleting load balancing rules:
> > - Added logic to
> server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java to
> grab zone id and pass to publishUsageEvent
> >
> >
> > Diffs
> > -----
> >
> >   server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java
> be81a3e
> >
> > Diff: https://reviews.apache.org/r/15280/diff/
> >
> >
> > Testing
> > -------
> >
> > Testing only on 4.2
> >
> >
> > Thanks,
> >
> > David Grizzanti
> >
> >

Mime
View raw message