cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 18165: FindBugs findings: fixing equals() methods in 2 classes; commenting out dead variable in 1 class; adding 5 tests to cover the changes in the equals() methods.
Date Tue, 25 Feb 2014 13:47:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18165/#review35396
-----------------------------------------------------------

Ship it!


commit eee4fb50c8e4633a17050cb03485c9a81292bd2d
Author: wrodrigues <wrodrigues@schubergphilis.com>
Date:   Sat Feb 15 13:23:35 2014 +0100

    FindBugs findings: fixing equals() methods in 2 classes; commenting out dead variable
in 1 class; adding 5 tests to cover the changes in the equals() methods.
    
    Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>


- Hugo Trippaers


On Feb. 15, 2014, 12:42 p.m., Wilder Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18165/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 12:42 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed 2 equals() method implementations
> Added synchronized keyword to a get() method, because the set() is already synchronized
> Commented out a dead variable
> 
> 
> Diffs
> -----
> 
>   engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java 3ebaf4a 
>   engine/orchestration/src/com/cloud/agent/manager/ClusteredAgentAttache.java 23c3f76

>   engine/orchestration/src/com/cloud/agent/manager/ConnectedAgentAttache.java 00d54bb

>   engine/orchestration/src/org/apache/cloudstack/engine/service/api/ProvisioningServiceImpl.java
86eab58 
>   engine/orchestration/test/com/cloud/agent/manager/ConnectedAgentAttacheTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/18165/diff/
> 
> 
> Testing
> -------
> 
> Check style successfully executed;
> Build successfully executed
> 5 unit tests added in order to cover the changes.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message