cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 16385: Fix for CloudStack JIRA 4406
Date Mon, 24 Feb 2014 15:16:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16385/#review35276
-----------------------------------------------------------


I'll download and money test. please adjust the description to indicate that calling cleanup is the default (I hope it is) and that not calling it is the exception that helps with performance.

regards

- daan Hoogland


On Feb. 24, 2014, 2:38 p.m., Mandar Barve wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16385/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2014, 2:38 p.m.)
> 
> 
> Review request for cloudstack and daan Hoogland.
> 
> 
> Bugs: CLOUDSTACK-4406
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
>     JIRA 4406 expects removal of cleanString() call for performance improvements. This is called when building audit trail for command responses and used for removing sensitive data (passwords, secret keys) from the log buffer. All the API responses do not carry such sensitive information so pattern matching done by cleanString against all API response strings can be costly. 
> 
> I propose following for a solution:
> 
> * Modify BaseCmd class to add flags that will store cmd/response sensitivity
> * At init these flags will be set to false indicating no cmd req/resp carries sensitive data
> * any child api cmd class that will carry sensitive data in the req/resp should set the respective flags
> * before calling any logging function the flag should be checked and cleanString should be called only for cmds with flags set
> 
> Pro: This approach will scale well as new cmds get added and no additional changes should be required.
> Con: Big change upfront as it will touch all API cmd classes that carry sensitive information along with BaseCmd class. 
> 
> NOTE: changes should be simple and straightforward though spread across multiple classes.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/APICommand.java 5587a48 
>   api/src/org/apache/cloudstack/api/command/admin/account/CreateAccountCmd.java c5a2d1a 
>   api/src/org/apache/cloudstack/api/command/admin/account/DeleteAccountCmd.java 7c1b206 
>   api/src/org/apache/cloudstack/api/command/admin/account/DisableAccountCmd.java 6fdbefe 
>   api/src/org/apache/cloudstack/api/command/admin/account/EnableAccountCmd.java 59d6acd 
>   api/src/org/apache/cloudstack/api/command/admin/account/LockAccountCmd.java 93ec1be 
>   api/src/org/apache/cloudstack/api/command/admin/account/UpdateAccountCmd.java a8cf63f 
>   api/src/org/apache/cloudstack/api/command/admin/alert/GenerateAlertCmd.java 3eaa053 
>   api/src/org/apache/cloudstack/api/command/admin/autoscale/CreateCounterCmd.java 6c4b81b 
>   api/src/org/apache/cloudstack/api/command/admin/autoscale/DeleteCounterCmd.java 50477f5 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java d0e7380 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/DeleteClusterCmd.java e1bc585 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/ListClustersCmd.java 8640f37 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java b13f81a 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java 517807d 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListDeploymentPlannersCmd.java 1d9d2d9 
>   api/src/org/apache/cloudstack/api/command/admin/config/ListHypervisorCapabilitiesCmd.java 16adf66 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java 9bc9b3c 
>   api/src/org/apache/cloudstack/api/command/admin/config/UpdateHypervisorCapabilitiesCmd.java 5cb5f9c 
>   api/src/org/apache/cloudstack/api/command/admin/domain/CreateDomainCmd.java 4737555 
>   api/src/org/apache/cloudstack/api/command/admin/domain/DeleteDomainCmd.java b1075c1 
>   api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainChildrenCmd.java e1ba178 
>   api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java 5a3786c 
>   api/src/org/apache/cloudstack/api/command/admin/domain/UpdateDomainCmd.java 8acfcd5 
>   api/src/org/apache/cloudstack/api/command/admin/host/AddHostCmd.java 363bcd6 
>   api/src/org/apache/cloudstack/api/command/admin/host/AddSecondaryStorageCmd.java b573bea 
>   api/src/org/apache/cloudstack/api/command/admin/host/CancelMaintenanceCmd.java 46289ee 
>   api/src/org/apache/cloudstack/api/command/admin/host/DeleteHostCmd.java 5a4478e 
>   api/src/org/apache/cloudstack/api/command/admin/host/FindHostsForMigrationCmd.java 0faf72c 
>   api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java eda821b 
>   api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java 23cfacf 
>   api/src/org/apache/cloudstack/api/command/admin/host/ReconnectHostCmd.java 1ce888b 
>   api/src/org/apache/cloudstack/api/command/admin/host/ReleaseHostReservationCmd.java b60feca 
>   api/src/org/apache/cloudstack/api/command/admin/host/UpdateHostCmd.java d778b37 
>   api/src/org/apache/cloudstack/api/command/admin/host/UpdateHostPasswordCmd.java 69480b1 
>   api/src/org/apache/cloudstack/api/command/admin/internallb/ConfigureInternalLoadBalancerElementCmd.java 51da760 
>   api/src/org/apache/cloudstack/api/command/admin/internallb/CreateInternalLoadBalancerElementCmd.java a6ece72 
>   api/src/org/apache/cloudstack/api/command/admin/internallb/ListInternalLBVMsCmd.java 0e01be1 
>   api/src/org/apache/cloudstack/api/command/admin/internallb/ListInternalLoadBalancerElementsCmd.java a42a0b3 
>   api/src/org/apache/cloudstack/api/command/admin/internallb/StartInternalLBVMCmd.java 56dcb4f 
>   api/src/org/apache/cloudstack/api/command/admin/internallb/StopInternalLBVMCmd.java 9da4db0 
>   api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkDeviceCmd.java 7af9355 
>   api/src/org/apache/cloudstack/api/command/admin/network/AddNetworkServiceProviderCmd.java f190493 
>   api/src/org/apache/cloudstack/api/command/admin/network/CreateNetworkOfferingCmd.java 5614295 
>   api/src/org/apache/cloudstack/api/command/admin/network/CreatePhysicalNetworkCmd.java de4e5e5 
>   api/src/org/apache/cloudstack/api/command/admin/network/CreateStorageNetworkIpRangeCmd.java cfbbd36 
>   api/src/org/apache/cloudstack/api/command/admin/network/DedicateGuestVlanRangeCmd.java 51b4924 
>   api/src/org/apache/cloudstack/api/command/admin/network/DeleteNetworkDeviceCmd.java 96e4fa5 
>   api/src/org/apache/cloudstack/api/command/admin/network/DeleteNetworkOfferingCmd.java 3aa7d66 
>   api/src/org/apache/cloudstack/api/command/admin/network/DeleteNetworkServiceProviderCmd.java c4993c3 
>   api/src/org/apache/cloudstack/api/command/admin/network/DeletePhysicalNetworkCmd.java 828683a 
>   api/src/org/apache/cloudstack/api/command/admin/network/DeleteStorageNetworkIpRangeCmd.java 42c9619 
>   api/src/org/apache/cloudstack/api/command/admin/network/ListDedicatedGuestVlanRangesCmd.java ca7c1f7 
>   api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkDeviceCmd.java de175d0 
>   api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkIsolationMethodsCmd.java d30f7b8 
>   api/src/org/apache/cloudstack/api/command/admin/network/ListNetworkServiceProvidersCmd.java 5a1235b 
>   api/src/org/apache/cloudstack/api/command/admin/network/ListPhysicalNetworksCmd.java 3ac2faa 
>   api/src/org/apache/cloudstack/api/command/admin/network/ListStorageNetworkIpRangeCmd.java 89cba47 
>   api/src/org/apache/cloudstack/api/command/admin/network/ListSupportedNetworkServicesCmd.java 342f9b0 
>   api/src/org/apache/cloudstack/api/command/admin/network/ReleaseDedicatedGuestVlanRangeCmd.java 43e1149 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkOfferingCmd.java 957450f 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdateNetworkServiceProviderCmd.java c530c53 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java f808424 
>   api/src/org/apache/cloudstack/api/command/admin/network/UpdateStorageNetworkIpRangeCmd.java 9fd084a 
>   api/src/org/apache/cloudstack/api/command/admin/offering/CreateDiskOfferingCmd.java 1d959a0 
>   api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java 6f9693c 
>   api/src/org/apache/cloudstack/api/command/admin/offering/DeleteDiskOfferingCmd.java 9845aa4 
>   api/src/org/apache/cloudstack/api/command/admin/offering/DeleteServiceOfferingCmd.java 0f81409 
>   api/src/org/apache/cloudstack/api/command/admin/offering/UpdateDiskOfferingCmd.java 6d45fb5 
>   api/src/org/apache/cloudstack/api/command/admin/offering/UpdateServiceOfferingCmd.java fbc8845 
>   api/src/org/apache/cloudstack/api/command/admin/pod/CreatePodCmd.java 835a3b9 
>   api/src/org/apache/cloudstack/api/command/admin/pod/DeletePodCmd.java 584eed4 
>   api/src/org/apache/cloudstack/api/command/admin/pod/ListPodsByCmd.java 75b5efd 
>   api/src/org/apache/cloudstack/api/command/admin/pod/UpdatePodCmd.java 7b8f6eb 
>   api/src/org/apache/cloudstack/api/command/admin/region/AddRegionCmd.java 9e7c035 
>   api/src/org/apache/cloudstack/api/command/admin/region/CreatePortableIpRangeCmd.java e900f47 
>   api/src/org/apache/cloudstack/api/command/admin/region/DeletePortableIpRangeCmd.java 5408eda 
>   api/src/org/apache/cloudstack/api/command/admin/region/ListPortableIpRangesCmd.java 42a92e6 
>   api/src/org/apache/cloudstack/api/command/admin/region/RemoveRegionCmd.java e912659 
>   api/src/org/apache/cloudstack/api/command/admin/region/UpdateRegionCmd.java 527e142 
>   api/src/org/apache/cloudstack/api/command/admin/resource/ArchiveAlertsCmd.java b1177b9 
>   api/src/org/apache/cloudstack/api/command/admin/resource/CleanVMReservationsCmd.java edc3bcf 
>   api/src/org/apache/cloudstack/api/command/admin/resource/DeleteAlertsCmd.java 8ba2525 
>   api/src/org/apache/cloudstack/api/command/admin/resource/ListAlertsCmd.java 397b00a 
>   api/src/org/apache/cloudstack/api/command/admin/resource/ListCapacityCmd.java 2b0f827 
>   api/src/org/apache/cloudstack/api/command/admin/resource/UploadCustomCertificateCmd.java 68ef5ac 
>   api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java 75b08b1 
>   api/src/org/apache/cloudstack/api/command/admin/router/ConfigureVirtualRouterElementCmd.java 2cfefda 
>   api/src/org/apache/cloudstack/api/command/admin/router/CreateVirtualRouterElementCmd.java bf5eb18 
>   api/src/org/apache/cloudstack/api/command/admin/router/DestroyRouterCmd.java 2ad312e 
>   api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java d5f73fd 
>   api/src/org/apache/cloudstack/api/command/admin/router/ListRoutersCmd.java 9c91e0f 
>   api/src/org/apache/cloudstack/api/command/admin/router/ListVirtualRouterElementsCmd.java 6f17921 
>   api/src/org/apache/cloudstack/api/command/admin/router/RebootRouterCmd.java 15527d3 
>   api/src/org/apache/cloudstack/api/command/admin/router/StartRouterCmd.java 9196cd0 
>   api/src/org/apache/cloudstack/api/command/admin/router/StopRouterCmd.java ee2b9eb 
>   api/src/org/apache/cloudstack/api/command/admin/router/UpgradeRouterCmd.java 04a4e67 
>   api/src/org/apache/cloudstack/api/command/admin/router/UpgradeRouterTemplateCmd.java 4947745 
>   api/src/org/apache/cloudstack/api/command/admin/storage/AddImageStoreCmd.java 5e5bd3d 
>   api/src/org/apache/cloudstack/api/command/admin/storage/AddS3Cmd.java 32897e4 
>   api/src/org/apache/cloudstack/api/command/admin/storage/CancelPrimaryStorageMaintenanceCmd.java b1c5594 
>   api/src/org/apache/cloudstack/api/command/admin/storage/CreateSecondaryStagingStoreCmd.java 1480e75 
>   api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java dfd0026 
>   api/src/org/apache/cloudstack/api/command/admin/storage/DeleteImageStoreCmd.java 602da83 
>   api/src/org/apache/cloudstack/api/command/admin/storage/DeletePoolCmd.java fb63daa 
>   api/src/org/apache/cloudstack/api/command/admin/storage/DeleteSecondaryStagingStoreCmd.java caf937f 
>   api/src/org/apache/cloudstack/api/command/admin/storage/FindStoragePoolsForMigrationCmd.java 10813ca 
>   api/src/org/apache/cloudstack/api/command/admin/storage/ListImageStoresCmd.java bf47084 
>   api/src/org/apache/cloudstack/api/command/admin/storage/ListS3sCmd.java 362d69e 
>   api/src/org/apache/cloudstack/api/command/admin/storage/ListSecondaryStagingStoresCmd.java 171f971 
>   api/src/org/apache/cloudstack/api/command/admin/storage/ListStoragePoolsCmd.java 868b402 
>   api/src/org/apache/cloudstack/api/command/admin/storage/ListStorageProvidersCmd.java bac6b7c 
>   api/src/org/apache/cloudstack/api/command/admin/storage/PreparePrimaryStorageForMaintenanceCmd.java 9d11966 
>   api/src/org/apache/cloudstack/api/command/admin/storage/UpdateCloudToUseObjectStoreCmd.java 983a01c 
>   api/src/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java 50be6ba 
>   api/src/org/apache/cloudstack/api/command/admin/swift/AddSwiftCmd.java 173c95e 
>   api/src/org/apache/cloudstack/api/command/admin/swift/ListSwiftsCmd.java fcc8e46 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/DestroySystemVmCmd.java 07e111c 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/ListSystemVMsCmd.java 9480497 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/MigrateSystemVMCmd.java 8199e68 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/RebootSystemVmCmd.java 1c38b05 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java 370815d 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/StartSystemVMCmd.java 2e65928 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/StopSystemVmCmd.java 7709ebe 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java da0564e 
>   api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java 16761ba 
>   api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficMonitorCmd.java 031fc8d 
>   api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficTypeCmd.java 0fcb8f8 
>   api/src/org/apache/cloudstack/api/command/admin/usage/DeleteTrafficMonitorCmd.java debaf00 
>   api/src/org/apache/cloudstack/api/command/admin/usage/DeleteTrafficTypeCmd.java 111e177 
>   api/src/org/apache/cloudstack/api/command/admin/usage/GenerateUsageRecordsCmd.java 4fc36ab 
>   api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java a8bd1e5 
>   api/src/org/apache/cloudstack/api/command/admin/usage/ListTrafficMonitorsCmd.java 3592539 
>   api/src/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypeImplementorsCmd.java 159608e 
>   api/src/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypesCmd.java 47ba781 
>   api/src/org/apache/cloudstack/api/command/admin/usage/ListUsageTypesCmd.java b5e445b 
>   api/src/org/apache/cloudstack/api/command/admin/usage/UpdateTrafficTypeCmd.java 2ad470e 
>   api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.java 03512db 
>   api/src/org/apache/cloudstack/api/command/admin/user/DeleteUserCmd.java 6ba382a 
>   api/src/org/apache/cloudstack/api/command/admin/user/DisableUserCmd.java 599328d 
>   api/src/org/apache/cloudstack/api/command/admin/user/EnableUserCmd.java 8d37eda 
>   api/src/org/apache/cloudstack/api/command/admin/user/GetUserCmd.java 592b828 
>   api/src/org/apache/cloudstack/api/command/admin/user/ListUsersCmd.java 41d6acd 
>   api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.java 9533004 
>   api/src/org/apache/cloudstack/api/command/admin/user/RegisterCmd.java facdc87 
>   api/src/org/apache/cloudstack/api/command/admin/user/UpdateUserCmd.java de6e550 
>   api/src/org/apache/cloudstack/api/command/admin/vlan/CreateVlanIpRangeCmd.java cd3dd7e 
>   api/src/org/apache/cloudstack/api/command/admin/vlan/DedicatePublicIpRangeCmd.java 2650482 
>   api/src/org/apache/cloudstack/api/command/admin/vlan/DeleteVlanIpRangeCmd.java 8d29130 
>   api/src/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java 9d6eae6 
>   api/src/org/apache/cloudstack/api/command/admin/vlan/ReleasePublicIpRangeCmd.java 2c160be 
>   api/src/org/apache/cloudstack/api/command/admin/vm/AssignVMCmd.java c9b5c9f 
>   api/src/org/apache/cloudstack/api/command/admin/vm/ExpungeVMCmd.java 7b16686 
>   api/src/org/apache/cloudstack/api/command/admin/vm/GetVMUserDataCmd.java 0e52714 
>   api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java 3706d50 
>   api/src/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java 90918bf 
>   api/src/org/apache/cloudstack/api/command/admin/vm/RecoverVMCmd.java abf5168 
>   api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java c3201f1 
>   api/src/org/apache/cloudstack/api/command/admin/vpc/CreateVPCOfferingCmd.java 96d5c6a 
>   api/src/org/apache/cloudstack/api/command/admin/vpc/DeletePrivateGatewayCmd.java a5bb00c 
>   api/src/org/apache/cloudstack/api/command/admin/vpc/DeleteVPCOfferingCmd.java 7abaa7d 
>   api/src/org/apache/cloudstack/api/command/admin/vpc/UpdateVPCOfferingCmd.java 3526b4b 
>   api/src/org/apache/cloudstack/api/command/admin/zone/CreateZoneCmd.java 0846102 
>   api/src/org/apache/cloudstack/api/command/admin/zone/DeleteZoneCmd.java 3e74625 
>   api/src/org/apache/cloudstack/api/command/admin/zone/MarkDefaultZoneForAccountCmd.java fe2bc6a 
>   api/src/org/apache/cloudstack/api/command/admin/zone/UpdateZoneCmd.java f0074c5 
>   api/src/org/apache/cloudstack/api/command/user/account/AddAccountToProjectCmd.java 36df579 
>   api/src/org/apache/cloudstack/api/command/user/account/DeleteAccountFromProjectCmd.java f6aa36c 
>   api/src/org/apache/cloudstack/api/command/user/account/ListAccountsCmd.java bc93d21 
>   api/src/org/apache/cloudstack/api/command/user/account/ListProjectAccountsCmd.java aa60016 
>   api/src/org/apache/cloudstack/api/command/user/address/AssociateIPAddrCmd.java ed01c60 
>   api/src/org/apache/cloudstack/api/command/user/address/DisassociateIPAddrCmd.java e3669be 
>   api/src/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java a5c54ad 
>   api/src/org/apache/cloudstack/api/command/user/address/UpdateIPAddrCmd.java 16dcc4e 
>   api/src/org/apache/cloudstack/api/command/user/affinitygroup/CreateAffinityGroupCmd.java a2542a8 
>   api/src/org/apache/cloudstack/api/command/user/affinitygroup/DeleteAffinityGroupCmd.java a6cf1bb 
>   api/src/org/apache/cloudstack/api/command/user/affinitygroup/ListAffinityGroupTypesCmd.java 87de7f7 
>   api/src/org/apache/cloudstack/api/command/user/affinitygroup/ListAffinityGroupsCmd.java 0761a64 
>   api/src/org/apache/cloudstack/api/command/user/affinitygroup/UpdateVMAffinityGroupCmd.java 7bb1c5b 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScalePolicyCmd.java ce6dc68 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScaleVmGroupCmd.java ab6d847 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/CreateAutoScaleVmProfileCmd.java 06d86ec 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/CreateConditionCmd.java 914848a 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/DeleteAutoScalePolicyCmd.java 1aedf57 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/DeleteAutoScaleVmGroupCmd.java a7823b4 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/DeleteAutoScaleVmProfileCmd.java 3d6d030 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/DeleteConditionCmd.java 0cc2319 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/DisableAutoScaleVmGroupCmd.java 2bd6f87 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/EnableAutoScaleVmGroupCmd.java dc89f2b 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScalePoliciesCmd.java 84ed30a 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmGroupsCmd.java 4eda7a8 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/ListAutoScaleVmProfilesCmd.java 5b4a46e 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/ListConditionsCmd.java 015f3ed 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/ListCountersCmd.java f503b2b 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/UpdateAutoScalePolicyCmd.java 91adeb1 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/UpdateAutoScaleVmGroupCmd.java 0c8dc1c 
>   api/src/org/apache/cloudstack/api/command/user/autoscale/UpdateAutoScaleVmProfileCmd.java 20d4d0e 
>   api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java 5c00814 
>   api/src/org/apache/cloudstack/api/command/user/event/ArchiveEventsCmd.java e51f850 
>   api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java d00b58d 
>   api/src/org/apache/cloudstack/api/command/user/event/ListEventTypesCmd.java 7a58d4c 
>   api/src/org/apache/cloudstack/api/command/user/event/ListEventsCmd.java 0e45e4e 
>   api/src/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java 22c8860 
>   api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java 9ec2efd 
>   api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java d441271 
>   api/src/org/apache/cloudstack/api/command/user/firewall/DeleteEgressFirewallRuleCmd.java 8e7b679 
>   api/src/org/apache/cloudstack/api/command/user/firewall/DeleteFirewallRuleCmd.java c3029b8 
>   api/src/org/apache/cloudstack/api/command/user/firewall/DeletePortForwardingRuleCmd.java c493dd0 
>   api/src/org/apache/cloudstack/api/command/user/firewall/ListEgressFirewallRulesCmd.java 4ac94df 
>   api/src/org/apache/cloudstack/api/command/user/firewall/ListFirewallRulesCmd.java 44d26e4 
>   api/src/org/apache/cloudstack/api/command/user/firewall/ListPortForwardingRulesCmd.java bd8a7a1 
>   api/src/org/apache/cloudstack/api/command/user/firewall/UpdateEgressFirewallRuleCmd.java 43b9a61 
>   api/src/org/apache/cloudstack/api/command/user/firewall/UpdateFirewallRuleCmd.java f6411d0 
>   api/src/org/apache/cloudstack/api/command/user/firewall/UpdatePortForwardingRuleCmd.java f7ee86f 
>   api/src/org/apache/cloudstack/api/command/user/guest/ListGuestOsCategoriesCmd.java 604f1ed 
>   api/src/org/apache/cloudstack/api/command/user/guest/ListGuestOsCmd.java 287fb1e 
>   api/src/org/apache/cloudstack/api/command/user/iso/AttachIsoCmd.java d38c816 
>   api/src/org/apache/cloudstack/api/command/user/iso/CopyIsoCmd.java 3619318 
>   api/src/org/apache/cloudstack/api/command/user/iso/DeleteIsoCmd.java 91ad5f1 
>   api/src/org/apache/cloudstack/api/command/user/iso/DetachIsoCmd.java e40195b 
>   api/src/org/apache/cloudstack/api/command/user/iso/ExtractIsoCmd.java 2fb215a 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsoPermissionsCmd.java 9d9e44b 
>   api/src/org/apache/cloudstack/api/command/user/iso/ListIsosCmd.java 95b771f 
>   api/src/org/apache/cloudstack/api/command/user/iso/RegisterIsoCmd.java 29e3d67 
>   api/src/org/apache/cloudstack/api/command/user/iso/UpdateIsoCmd.java 6a471c9 
>   api/src/org/apache/cloudstack/api/command/user/iso/UpdateIsoPermissionsCmd.java 8267b5c 
>   api/src/org/apache/cloudstack/api/command/user/job/ListAsyncJobsCmd.java 9d45d50 
>   api/src/org/apache/cloudstack/api/command/user/job/QueryAsyncJobResultCmd.java 1f9f5db 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java 4b0ea54 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java bcf6200 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateApplicationLoadBalancerCmd.java 94a1eaa 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLBHealthCheckPolicyCmd.java 5ff7239 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLBStickinessPolicyCmd.java 159fcf5 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java 71349af 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteApplicationLoadBalancerCmd.java 0b53d53 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteLBHealthCheckPolicyCmd.java d625ed5 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteLBStickinessPolicyCmd.java c4f72d9 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteLoadBalancerRuleCmd.java 1dc3cd1 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java d5683b0 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListApplicationLoadBalancersCmd.java 05572c8 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLBHealthCheckPoliciesCmd.java 8aa286f 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLBStickinessPoliciesCmd.java ade4878 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java 2a39e1a 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRulesCmd.java 663f991 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java 7f8118a 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java ea420f3 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveFromLoadBalancerRuleCmd.java 5027ad3 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/UpdateApplicationLoadBalancerCmd.java e475416 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/UpdateLoadBalancerRuleCmd.java 24f06e0 
>   api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java 00bd013 
>   api/src/org/apache/cloudstack/api/command/user/nat/CreateIpForwardingRuleCmd.java 320375c 
>   api/src/org/apache/cloudstack/api/command/user/nat/DeleteIpForwardingRuleCmd.java 66a9f8a 
>   api/src/org/apache/cloudstack/api/command/user/nat/DisableStaticNatCmd.java 351d3ae 
>   api/src/org/apache/cloudstack/api/command/user/nat/EnableStaticNatCmd.java 832cbc2 
>   api/src/org/apache/cloudstack/api/command/user/nat/ListIpForwardingRulesCmd.java dca1c23 
>   api/src/org/apache/cloudstack/api/command/user/network/CreateNetworkACLCmd.java 151e42f 
>   api/src/org/apache/cloudstack/api/command/user/network/CreateNetworkACLListCmd.java 24c3a85 
>   api/src/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java 018f16e 
>   api/src/org/apache/cloudstack/api/command/user/network/DeleteNetworkACLCmd.java 7413ea5 
>   api/src/org/apache/cloudstack/api/command/user/network/DeleteNetworkACLListCmd.java 632d710 
>   api/src/org/apache/cloudstack/api/command/user/network/DeleteNetworkCmd.java 808051e 
>   api/src/org/apache/cloudstack/api/command/user/network/ListNetworkACLListsCmd.java 2e50bb8 
>   api/src/org/apache/cloudstack/api/command/user/network/ListNetworkACLsCmd.java 7f8aef4 
>   api/src/org/apache/cloudstack/api/command/user/network/ListNetworkOfferingsCmd.java 552a64a 
>   api/src/org/apache/cloudstack/api/command/user/network/ListNetworksCmd.java 111fac3 
>   api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java de1f163 
>   api/src/org/apache/cloudstack/api/command/user/network/RestartNetworkCmd.java cd508ff 
>   api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLItemCmd.java 82985d0 
>   api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkACLListCmd.java 1170e9e 
>   api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java e327de1 
>   api/src/org/apache/cloudstack/api/command/user/offering/ListDiskOfferingsCmd.java 954b64e 
>   api/src/org/apache/cloudstack/api/command/user/offering/ListServiceOfferingsCmd.java 08c69e8 
>   api/src/org/apache/cloudstack/api/command/user/project/ActivateProjectCmd.java 66c64a6 
>   api/src/org/apache/cloudstack/api/command/user/project/CreateProjectCmd.java dcb83a8 
>   api/src/org/apache/cloudstack/api/command/user/project/DeleteProjectCmd.java 88205e8 
>   api/src/org/apache/cloudstack/api/command/user/project/DeleteProjectInvitationCmd.java 9d4d838 
>   api/src/org/apache/cloudstack/api/command/user/project/ListProjectInvitationsCmd.java 0e9e7ae 
>   api/src/org/apache/cloudstack/api/command/user/project/ListProjectsCmd.java 2cf6106 
>   api/src/org/apache/cloudstack/api/command/user/project/SuspendProjectCmd.java c2a1885 
>   api/src/org/apache/cloudstack/api/command/user/project/UpdateProjectCmd.java 78903bf 
>   api/src/org/apache/cloudstack/api/command/user/project/UpdateProjectInvitationCmd.java dda7b54 
>   api/src/org/apache/cloudstack/api/command/user/region/ListRegionsCmd.java c369b9c 
>   api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/AssignToGlobalLoadBalancerRuleCmd.java 1fe73b5 
>   api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/CreateGlobalLoadBalancerRuleCmd.java 550d817 
>   api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/DeleteGlobalLoadBalancerRuleCmd.java 2e96965 
>   api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/ListGlobalLoadBalancerRuleCmd.java f37aba2 
>   api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/RemoveFromGlobalLoadBalancerRuleCmd.java b30f4d8 
>   api/src/org/apache/cloudstack/api/command/user/region/ha/gslb/UpdateGlobalLoadBalancerRuleCmd.java e8c5326 
>   api/src/org/apache/cloudstack/api/command/user/resource/GetCloudIdentifierCmd.java ccaca2d 
>   api/src/org/apache/cloudstack/api/command/user/resource/ListHypervisorsCmd.java 5e546f4 
>   api/src/org/apache/cloudstack/api/command/user/resource/ListResourceLimitsCmd.java ba3cfc8 
>   api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java bd4f995 
>   api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java c33a9e7 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupEgressCmd.java 6a054a4 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupIngressCmd.java be91959 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/CreateSecurityGroupCmd.java 3b16821 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/DeleteSecurityGroupCmd.java 0bcc144 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/ListSecurityGroupsCmd.java ae745b3 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupEgressCmd.java 006aa7d 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupIngressCmd.java 0858578 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java a0f307b 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotPolicyCmd.java 5ecbaaa 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/DeleteSnapshotCmd.java 35caaff 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/DeleteSnapshotPoliciesCmd.java bcccf8b 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotPoliciesCmd.java 7c2899f 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java e4d566a 
>   api/src/org/apache/cloudstack/api/command/user/snapshot/RevertSnapshotCmd.java f11fa3f 
>   api/src/org/apache/cloudstack/api/command/user/ssh/CreateSSHKeyPairCmd.java 1fc9d13 
>   api/src/org/apache/cloudstack/api/command/user/ssh/DeleteSSHKeyPairCmd.java a638eb9 
>   api/src/org/apache/cloudstack/api/command/user/ssh/ListSSHKeyPairsCmd.java 52fca5f 
>   api/src/org/apache/cloudstack/api/command/user/ssh/RegisterSSHKeyPairCmd.java 8ed5cbd 
>   api/src/org/apache/cloudstack/api/command/user/tag/CreateTagsCmd.java ee0add4 
>   api/src/org/apache/cloudstack/api/command/user/tag/DeleteTagsCmd.java 3ee7c06 
>   api/src/org/apache/cloudstack/api/command/user/tag/ListTagsCmd.java 893f6df 
>   api/src/org/apache/cloudstack/api/command/user/template/CopyTemplateCmd.java 87f94f7 
>   api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java 0030a7e 
>   api/src/org/apache/cloudstack/api/command/user/template/DeleteTemplateCmd.java 890af70 
>   api/src/org/apache/cloudstack/api/command/user/template/ExtractTemplateCmd.java 082f46a 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatePermissionsCmd.java 08acf63 
>   api/src/org/apache/cloudstack/api/command/user/template/ListTemplatesCmd.java d393c6a 
>   api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 48ed6ea 
>   api/src/org/apache/cloudstack/api/command/user/template/UpdateTemplateCmd.java f80a4ee 
>   api/src/org/apache/cloudstack/api/command/user/template/UpdateTemplatePermissionsCmd.java 96d1f55 
>   api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java 439879a 
>   api/src/org/apache/cloudstack/api/command/user/vm/AddNicToVMCmd.java 43efe16 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 055832e 
>   api/src/org/apache/cloudstack/api/command/user/vm/DestroyVMCmd.java 3c63e8d 
>   api/src/org/apache/cloudstack/api/command/user/vm/GetVMPasswordCmd.java d0503d1 
>   api/src/org/apache/cloudstack/api/command/user/vm/ListNicsCmd.java 95d4990 
>   api/src/org/apache/cloudstack/api/command/user/vm/ListVMsCmd.java 28637fb 
>   api/src/org/apache/cloudstack/api/command/user/vm/RebootVMCmd.java 7ac9138 
>   api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java 2458247 
>   api/src/org/apache/cloudstack/api/command/user/vm/RemoveNicFromVMCmd.java 92becb7 
>   api/src/org/apache/cloudstack/api/command/user/vm/ResetVMPasswordCmd.java df34120 
>   api/src/org/apache/cloudstack/api/command/user/vm/ResetVMSSHKeyCmd.java 7436e3d 
>   api/src/org/apache/cloudstack/api/command/user/vm/RestoreVMCmd.java b69b364 
>   api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java d234300 
>   api/src/org/apache/cloudstack/api/command/user/vm/StartVMCmd.java 4239a64 
>   api/src/org/apache/cloudstack/api/command/user/vm/StopVMCmd.java 17f12f9 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpdateDefaultNicForVMCmd.java f699cce 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java 1b5613c 
>   api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 12ab711 
>   api/src/org/apache/cloudstack/api/command/user/vmgroup/CreateVMGroupCmd.java 937fca3 
>   api/src/org/apache/cloudstack/api/command/user/vmgroup/DeleteVMGroupCmd.java fbfb85a 
>   api/src/org/apache/cloudstack/api/command/user/vmgroup/ListVMGroupsCmd.java fda3e88 
>   api/src/org/apache/cloudstack/api/command/user/vmgroup/UpdateVMGroupCmd.java 1930bd8 
>   api/src/org/apache/cloudstack/api/command/user/vmsnapshot/CreateVMSnapshotCmd.java de921f6 
>   api/src/org/apache/cloudstack/api/command/user/vmsnapshot/DeleteVMSnapshotCmd.java d29ff05 
>   api/src/org/apache/cloudstack/api/command/user/vmsnapshot/ListVMSnapshotCmd.java 84b552c 
>   api/src/org/apache/cloudstack/api/command/user/vmsnapshot/RevertToVMSnapshotCmd.java cec2154 
>   api/src/org/apache/cloudstack/api/command/user/volume/AddResourceDetailCmd.java 8c6713d 
>   api/src/org/apache/cloudstack/api/command/user/volume/AttachVolumeCmd.java cd1e1ed 
>   api/src/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java ebade66 
>   api/src/org/apache/cloudstack/api/command/user/volume/DeleteVolumeCmd.java 550adb9 
>   api/src/org/apache/cloudstack/api/command/user/volume/DetachVolumeCmd.java 70283ff 
>   api/src/org/apache/cloudstack/api/command/user/volume/ExtractVolumeCmd.java d73143a 
>   api/src/org/apache/cloudstack/api/command/user/volume/ListResourceDetailsCmd.java 2f86c92 
>   api/src/org/apache/cloudstack/api/command/user/volume/ListVolumesCmd.java 4ebe3bf 
>   api/src/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java fa6ac69 
>   api/src/org/apache/cloudstack/api/command/user/volume/RemoveResourceDetailCmd.java c4c7554 
>   api/src/org/apache/cloudstack/api/command/user/volume/ResizeVolumeCmd.java e691944 
>   api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java 9f501bf 
>   api/src/org/apache/cloudstack/api/command/user/volume/UploadVolumeCmd.java 991cfc1 
>   api/src/org/apache/cloudstack/api/command/user/vpc/CreateStaticRouteCmd.java f2d2bce 
>   api/src/org/apache/cloudstack/api/command/user/vpc/CreateVPCCmd.java dfec95c 
>   api/src/org/apache/cloudstack/api/command/user/vpc/DeleteStaticRouteCmd.java 937341e 
>   api/src/org/apache/cloudstack/api/command/user/vpc/DeleteVPCCmd.java 14f21ba 
>   api/src/org/apache/cloudstack/api/command/user/vpc/ListPrivateGatewaysCmd.java 7870673 
>   api/src/org/apache/cloudstack/api/command/user/vpc/ListStaticRoutesCmd.java 931431b 
>   api/src/org/apache/cloudstack/api/command/user/vpc/ListVPCOfferingsCmd.java e3d0bc6 
>   api/src/org/apache/cloudstack/api/command/user/vpc/ListVPCsCmd.java 45ab863 
>   api/src/org/apache/cloudstack/api/command/user/vpc/RestartVPCCmd.java eb048ce 
>   api/src/org/apache/cloudstack/api/command/user/vpc/UpdateVPCCmd.java 1900def 
>   api/src/org/apache/cloudstack/api/command/user/vpn/AddVpnUserCmd.java 7c58117 
>   api/src/org/apache/cloudstack/api/command/user/vpn/CreateRemoteAccessVpnCmd.java a5e8d62 
>   api/src/org/apache/cloudstack/api/command/user/vpn/CreateVpnConnectionCmd.java bd603e1 
>   api/src/org/apache/cloudstack/api/command/user/vpn/CreateVpnCustomerGatewayCmd.java 821a4b0 
>   api/src/org/apache/cloudstack/api/command/user/vpn/CreateVpnGatewayCmd.java a48159f 
>   api/src/org/apache/cloudstack/api/command/user/vpn/DeleteRemoteAccessVpnCmd.java 41a8f1e 
>   api/src/org/apache/cloudstack/api/command/user/vpn/DeleteVpnConnectionCmd.java c86cc59 
>   api/src/org/apache/cloudstack/api/command/user/vpn/DeleteVpnCustomerGatewayCmd.java 4c777d7 
>   api/src/org/apache/cloudstack/api/command/user/vpn/DeleteVpnGatewayCmd.java 85f4004 
>   api/src/org/apache/cloudstack/api/command/user/vpn/ListRemoteAccessVpnsCmd.java 01e6d37 
>   api/src/org/apache/cloudstack/api/command/user/vpn/ListVpnConnectionsCmd.java 8de6059 
>   api/src/org/apache/cloudstack/api/command/user/vpn/ListVpnCustomerGatewaysCmd.java 5cd4bfb 
>   api/src/org/apache/cloudstack/api/command/user/vpn/ListVpnGatewaysCmd.java 75a5e81 
>   api/src/org/apache/cloudstack/api/command/user/vpn/ListVpnUsersCmd.java 5136633 
>   api/src/org/apache/cloudstack/api/command/user/vpn/RemoveVpnUserCmd.java 4eeef67 
>   api/src/org/apache/cloudstack/api/command/user/vpn/ResetVpnConnectionCmd.java efe6db8 
>   api/src/org/apache/cloudstack/api/command/user/vpn/UpdateRemoteAccessVpnCmd.java 9f552db 
>   api/src/org/apache/cloudstack/api/command/user/vpn/UpdateVpnConnectionCmd.java 662187c 
>   api/src/org/apache/cloudstack/api/command/user/vpn/UpdateVpnCustomerGatewayCmd.java 5694a74 
>   api/src/org/apache/cloudstack/api/command/user/vpn/UpdateVpnGatewayCmd.java eabc04a 
>   api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java 471e6d6 
>   plugins/api/discovery/src/org/apache/cloudstack/api/command/user/discovery/ListApisCmd.java 206d793 
>   plugins/api/rate-limit/src/org/apache/cloudstack/api/command/admin/ratelimit/ResetApiLimitCmd.java 9e415e6 
>   plugins/api/rate-limit/src/org/apache/cloudstack/api/command/user/ratelimit/GetApiLimitCmd.java 2428895 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/DedicateClusterCmd.java 4f8cd8c 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/DedicateHostCmd.java d3cce5a 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/DedicatePodCmd.java e823fd5 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/DedicateZoneCmd.java 0e427aa 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ListDedicatedClustersCmd.java a2022a5 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ListDedicatedHostsCmd.java d3b326d 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ListDedicatedPodsCmd.java d7cd4c2 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ListDedicatedZonesCmd.java 07b8b19 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ReleaseDedicatedClusterCmd.java e065da2 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ReleaseDedicatedHostCmd.java 41e668c 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ReleaseDedicatedPodCmd.java 47ea475 
>   plugins/dedicated-resources/src/org/apache/cloudstack/api/commands/ReleaseDedicatedZoneCmd.java 69185d6 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/AssociateLunCmd.java b698daa 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/CreateLunCmd.java 86b2497 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/CreateVolumeOnFilerCmd.java e79aa14 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/CreateVolumePoolCmd.java ba74933 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/DeleteVolumePoolCmd.java 1d221e9 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/DestroyLunCmd.java e0c0eb7 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/DestroyVolumeOnFilerCmd.java 680c4e5 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/DissociateLunCmd.java 4ea9684 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/ListLunsCmd.java 04e64f3 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/ListVolumePoolsCmd.java 9e650e0 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/ListVolumesOnFilerCmd.java 38c91b7 
>   plugins/file-systems/netapp/src/com/cloud/api/commands/netapp/ModifyVolumePoolCmd.java 94d5de5 
>   plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/AddBaremetalDhcpCmd.java 529f988 
>   plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/AddBaremetalHostCmd.java 40ee6de 
>   plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/AddBaremetalKickStartPxeCmd.java ac8d9c7 
>   plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/AddBaremetalPxePingServerCmd.java b128a62 
>   plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/ListBaremetalDhcpCmd.java 7d0aba3 
>   plugins/hypervisors/baremetal/src/org/apache/cloudstack/api/ListBaremetalPxeServersCmd.java 437fa3f 
>   plugins/hypervisors/simulator/src/com/cloud/api/commands/ConfigureSimulatorCmd.java c27a363 
>   plugins/hypervisors/ucs/src/org/apache/cloudstack/api/AddUcsManagerCmd.java 17cd3ab 
>   plugins/hypervisors/ucs/src/org/apache/cloudstack/api/AssociateUcsProfileToBladeCmd.java caea0be 
>   plugins/hypervisors/ucs/src/org/apache/cloudstack/api/DeleteUcsManagerCmd.java 566ee30 
>   plugins/hypervisors/ucs/src/org/apache/cloudstack/api/ListUcsBladeCmd.java 41c7cc1 
>   plugins/hypervisors/ucs/src/org/apache/cloudstack/api/ListUcsManagerCmd.java 767682f 
>   plugins/hypervisors/ucs/src/org/apache/cloudstack/api/ListUcsProfileCmd.java cc49cef 
>   plugins/hypervisors/vmware/src/com/cloud/api/commands/DeleteCiscoNexusVSMCmd.java 9e19719 
>   plugins/hypervisors/vmware/src/com/cloud/api/commands/DisableCiscoNexusVSMCmd.java 0e4d306 
>   plugins/hypervisors/vmware/src/com/cloud/api/commands/EnableCiscoNexusVSMCmd.java 63c79fb 
>   plugins/hypervisors/vmware/src/com/cloud/api/commands/ListCiscoNexusVSMsCmd.java 381bfc9 
>   plugins/hypervisors/vmware/src/org/apache/cloudstack/api/command/admin/zone/AddVmwareDcCmd.java 8a8f98a 
>   plugins/hypervisors/vmware/src/org/apache/cloudstack/api/command/admin/zone/ListVmwareDcsCmd.java 9fbf09a 
>   plugins/hypervisors/vmware/src/org/apache/cloudstack/api/command/admin/zone/RemoveVmwareDcCmd.java 6314139 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java a30059d 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java 4af45b2 
>   plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java 6e4ee75 
>   plugins/network-elements/cisco-vnmc/src/com/cloud/api/commands/AddCiscoAsa1000vResourceCmd.java c7e7d30 
>   plugins/network-elements/cisco-vnmc/src/com/cloud/api/commands/AddCiscoVnmcResourceCmd.java b33d1a8 
>   plugins/network-elements/cisco-vnmc/src/com/cloud/api/commands/DeleteCiscoAsa1000vResourceCmd.java 5af7299 
>   plugins/network-elements/cisco-vnmc/src/com/cloud/api/commands/DeleteCiscoVnmcResourceCmd.java ee13ae6 
>   plugins/network-elements/cisco-vnmc/src/com/cloud/api/commands/ListCiscoAsa1000vResourcesCmd.java 72898ae 
>   plugins/network-elements/cisco-vnmc/src/com/cloud/api/commands/ListCiscoVnmcResourcesCmd.java 4b0a6b5 
>   plugins/network-elements/f5/src/com/cloud/api/commands/AddExternalLoadBalancerCmd.java ff653e7 
>   plugins/network-elements/f5/src/com/cloud/api/commands/AddF5LoadBalancerCmd.java ba98882 
>   plugins/network-elements/f5/src/com/cloud/api/commands/ConfigureF5LoadBalancerCmd.java dc33984 
>   plugins/network-elements/f5/src/com/cloud/api/commands/DeleteExternalLoadBalancerCmd.java 63a9041 
>   plugins/network-elements/f5/src/com/cloud/api/commands/DeleteF5LoadBalancerCmd.java 2bb6c1c 
>   plugins/network-elements/f5/src/com/cloud/api/commands/ListExternalLoadBalancersCmd.java 119718c 
>   plugins/network-elements/f5/src/com/cloud/api/commands/ListF5LoadBalancerNetworksCmd.java d671a6b 
>   plugins/network-elements/f5/src/com/cloud/api/commands/ListF5LoadBalancersCmd.java ce8eb20 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 50457d8 
>   plugins/network-elements/juniper-srx/src/com/cloud/api/commands/AddExternalFirewallCmd.java 96e9bc0 
>   plugins/network-elements/juniper-srx/src/com/cloud/api/commands/AddSrxFirewallCmd.java 53e7bfc 
>   plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ConfigureSrxFirewallCmd.java 303e987 
>   plugins/network-elements/juniper-srx/src/com/cloud/api/commands/DeleteExternalFirewallCmd.java b24aa05 
>   plugins/network-elements/juniper-srx/src/com/cloud/api/commands/DeleteSrxFirewallCmd.java 75aadc2 
>   plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListExternalFirewallsCmd.java f87574e 
>   plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListSrxFirewallNetworksCmd.java a2d99a5 
>   plugins/network-elements/juniper-srx/src/com/cloud/api/commands/ListSrxFirewallsCmd.java e8cdcd5 
>   plugins/network-elements/netscaler/src/com/cloud/api/commands/AddNetscalerLoadBalancerCmd.java b744fff 
>   plugins/network-elements/netscaler/src/com/cloud/api/commands/ConfigureNetscalerLoadBalancerCmd.java f8bfd74 
>   plugins/network-elements/netscaler/src/com/cloud/api/commands/DeleteNetscalerLoadBalancerCmd.java f0f6747 
>   plugins/network-elements/netscaler/src/com/cloud/api/commands/ListNetscalerLoadBalancerNetworksCmd.java 25d1487 
>   plugins/network-elements/netscaler/src/com/cloud/api/commands/ListNetscalerLoadBalancersCmd.java 75d03d7 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/AddNiciraNvpDeviceCmd.java 37491fd 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/DeleteNiciraNvpDeviceCmd.java 685debb 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/ListNiciraNvpDeviceNetworksCmd.java 3fb711d 
>   plugins/network-elements/nicira-nvp/src/com/cloud/api/commands/ListNiciraNvpDevicesCmd.java 260d60f 
>   plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/api/commands/AddOpenDaylightControllerCmd.java 80130c0 
>   plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/api/commands/DeleteOpenDaylightControllerCmd.java b556504 
>   plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/api/commands/ListOpenDaylightControllersCmd.java f3e2e39 
>   plugins/network-elements/palo-alto/src/com/cloud/api/commands/AddPaloAltoFirewallCmd.java 7aba9c2 
>   plugins/network-elements/palo-alto/src/com/cloud/api/commands/ConfigurePaloAltoFirewallCmd.java 80f02ad 
>   plugins/network-elements/palo-alto/src/com/cloud/api/commands/DeletePaloAltoFirewallCmd.java 4f147eb 
>   plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallNetworksCmd.java d1b7425 
>   plugins/network-elements/palo-alto/src/com/cloud/api/commands/ListPaloAltoFirewallsCmd.java ad4be72 
>   plugins/network-elements/stratosphere-ssp/src/org/apache/cloudstack/api/commands/AddSspCmd.java 085f873 
>   plugins/network-elements/stratosphere-ssp/src/org/apache/cloudstack/api/commands/DeleteSspCmd.java e23f642 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPConfigCmd.java 5e424de 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LDAPRemoveCmd.java 535a545 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java 5686374 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java 100ffe6 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java b45bce5 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java 89cec65 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java b50970f 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListUsersCmd.java 5c65ac4 
>   plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java e2b050d 
>   server/src/com/cloud/api/ApiServer.java d715db6 
> 
> Diff: https://reviews.apache.org/r/16385/diff/
> 
> 
> Testing
> -------
> 
> Using CloudMonkey following commands have been tested to make sure secret key/password is stripped from the response
> list users
> list accounts
> list virtualmachines
> create user
> update user
> create sshkeypair
> 
> 
> Thanks,
> 
> Mandar Barve
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message