cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miguel Ferreira" <miguelferre...@me.com>
Subject Re: Review Request 18358: NetUtils unit testing
Date Sat, 22 Feb 2014 13:41:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18358/
-----------------------------------------------------------

(Updated Feb. 22, 2014, 1:41 p.m.)


Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Changes
-------

Add hamcrest dependency to pom (contribution of Laszio Hornyak)


Repository: cloudstack-git


Description
-------

- Refactor tests:
      - Upgrade tests to use jUnit4
      - Break big tests in small unit tests
      - Replace assertTrue/False with complex conditions by assertThat with
    specific matchers
    - Remove dead code:
      - Private static method never called locally
    - Add test for method that validates CIDRs


Diffs (updated)
-----

  pom.xml 1e9e8d8 
  utils/src/com/cloud/utils/net/NetUtils.java c22e39a 
  utils/test/com/cloud/utils/net/NetUtilsTest.java d3e283c 

Diff: https://reviews.apache.org/r/18358/diff/


Testing
-------

Ran all the tests in the test class before and after refactoring.


Thanks,

Miguel Ferreira


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message