cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 18117: CLOUDSTACK-4840: Adding first set of test cases for Multiple IPs per NIC feature
Date Mon, 17 Feb 2014 08:49:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18117/#review34639
-----------------------------------------------------------



tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/18117/#comment64831>

    All other seems to be ok, only one request here is not to raise asserts in library method,
use try\except block and assert in the test case based upon outcome.
    Also, please attach test case run log.


- Santhosh Edukulla


On Feb. 14, 2014, 1:01 p.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18117/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 1:01 p.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-4840
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4840
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adding first set of test cases for feature "Multiple IPs per NICs".
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_multiple_ips_per_nic.py PRE-CREATION 
>   tools/marvin/marvin/codes.py 74fb05d 
>   tools/marvin/marvin/integration/lib/base.py aa23029 
>   tools/marvin/marvin/integration/lib/common.py e202391 
> 
> Diff: https://reviews.apache.org/r/18117/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message