cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l
Date Fri, 14 Feb 2014 15:13:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18072/#review34493
-----------------------------------------------------------

Ship it!


commit 643301e031817cc4495fff5d37bd4970ca578c9c
Author: wrodrigues <wrodrigues@schubergphilis.com>
Date:   Tue Feb 11 11:15:55 2014 +0100

    Fixes on Contrail and Mon InMemory plugins; adding comments about the changes.
    
    Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>


- Hugo Trippaers


On Feb. 14, 2014, 2:43 p.m., Wilder Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18072/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 2:43 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing 11 scary and 1 of concern issues found by FindBugs. Adding 13 unit tests and also
1 validate method in the UuidUtils class.
> 
> 
> Diffs
> -----
> 
>   plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java
99d0a12 
>   plugins/event-bus/inmemory/test/org/apache/cloudstack/mom/inmemory/InMemoryEventBusTest.java
PRE-CREATION 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
b25de48 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
1b048ed 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
0ce22ad 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
4d0218c 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
b0505b1 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualMachineModelTest.java
f85beb6 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualNetworkModelTest.java
b1b5ae1 
>   utils/src/com/cloud/utils/UuidUtils.java 7831bea 
>   utils/test/com/cloud/utils/UuidUtilsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18072/diff/
> 
> 
> Testing
> -------
> 
> Build successfully and added 13 unit tests
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message