cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wilder Rodrigues" <wrodrig...@schubergphilis.com>
Subject Re: Review Request 18072: Fixing 11 scary and 1 of concern issues found by findBugs. Adding 13 unit tests and also 1 validate method in the UuidUtils class.l
Date Fri, 14 Feb 2014 13:52:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18072/
-----------------------------------------------------------

(Updated Feb. 14, 2014, 1:52 p.m.)


Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Changes
-------

Squashing the contrail and UuidUtils changes; adding comments about the changes I did i the
contrail plugin and also why the UUID.fromString() does not work properly; updating the unit
tests


Repository: cloudstack-git


Description
-------

Fixing 11 scary and 1 of concern issues found by FindBugs. Adding 13 unit tests and also 1
validate method in the UuidUtils class.


Diffs (updated)
-----

  plugins/event-bus/inmemory/src/org/apache/cloudstack/mom/inmemory/InMemoryEventBus.java
99d0a12 
  plugins/event-bus/inmemory/test/org/apache/cloudstack/mom/inmemory/InMemoryEventBusTest.java
PRE-CREATION 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
b25de48 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
1b048ed 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
0ce22ad 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
4d0218c 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
b0505b1 
  plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualMachineModelTest.java
f85beb6 
  plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualNetworkModelTest.java
b1b5ae1 
  utils/src/com/cloud/utils/UuidUtils.java 7831bea 
  utils/test/com/cloud/utils/UuidUtilsTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/18072/diff/


Testing
-------

Build successfully and added 13 unit tests


Thanks,

Wilder Rodrigues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message