cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 18116: Fix and test GroupBy SQL query creation
Date Fri, 14 Feb 2014 13:49:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18116/#review34485
-----------------------------------------------------------


Ian,

Can you upload a single patch file for this change? The current patch consists of several
patch files.

- Hugo Trippaers


On Feb. 14, 2014, 12:10 p.m., Ian Southam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18116/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2014, 12:10 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Findbugs finding fixed.
> 
> Incorrect String comparison (==)
> 
> Uncludes Unit Test (with thanks to Antonio)
> 
> 
> Diffs
> -----
> 
>   framework/db/src/com/cloud/utils/db/GroupBy.java 716b585 
>   framework/db/src/com/cloud/utils/db/SearchBase.java 3f123be 
>   framework/db/test/com/cloud/utils/db/GroupByTest.java PRE-CREATION 
>   plugins/affinity-group-processors/explicit-dedication/src/org/apache/cloudstack/affinity/ExplicitDedicationProcessor.java
8c253ee 
>   plugins/dedicated-resources/src/org/apache/cloudstack/dedicated/DedicatedResourceManagerImpl.java
b82b361 
>   plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ea46f93

>   plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java 6aacbb2

>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManager.java eaf2d66

>   plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java aa0f42e

>   plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
37861b4 
>   plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/provider/CloudStackPrimaryDataStoreProviderImpl.java
410416c 
>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxy.java 02fda64

>   services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyRdpClient.java
7d49b19 
>   services/console-proxy/server/test/com/cloud/consoleproxy/ConsoleProxyRdpClientTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18116/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Southam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message