cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wilder Rodrigues" <wrodrig...@schubergphilis.com>
Subject Re: Review Request 18066: Fixing troubling issues on contrail plugin found by FindBugs
Date Fri, 14 Feb 2014 11:56:34 GMT


> On Feb. 14, 2014, 10:18 a.m., Wilder Rodrigues wrote:
> >

This review will be discarded. The changes for the contrail plugin were squashed with another
commit.
A new patch will be uploaded to the review ID 18072


- Wilder


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18066/#review34476
-----------------------------------------------------------


On Feb. 13, 2014, 11:32 a.m., Wilder Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18066/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 11:32 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing troubling issues on contrail plugin related to dereference nullpoint; adding unit
tests to cover changes on the compare method on the VirtualNetworkModel
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailManagerImpl.java
b25de48 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ModelObject.java
1b048ed 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java
0ce22ad 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java
4d0218c 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualNetworkModel.java
b0505b1 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualMachineModelTest.java
f85beb6 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VirtualNetworkModelTest.java
b1b5ae1 
> 
> Diff: https://reviews.apache.org/r/18066/diff/
> 
> 
> Testing
> -------
> 
> Build successful + 3 unit tests added in order to cover compare methods cases.
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message