cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miguel Ferreira" <miguelferre...@me.com>
Subject Review Request 18113: Fix findbugs findings in cloud-plugin-network-elb
Date Fri, 14 Feb 2014 11:02:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18113/
-----------------------------------------------------------

Review request for cloudstack, daan Hoogland and Hugo Trippaers.


Repository: cloudstack-git


Description
-------

Fix findbugs findings in cloud-plugin-network-elb
    
    Findings:
    - comparing Longs by reference
    - possible null pointer dereference


Diffs
-----

  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 8b4433e 
  plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java
6dd0f8a 
  plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/LoadBalanceRuleHandler.java
PRE-CREATION 
  plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/ElasticLoadBalancerManagerImplTest.java
PRE-CREATION 
  plugins/network-elements/elastic-loadbalancer/test/com/cloud/network/lb/LoadBalanceRuleHandlerTest.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/18113/diff/


Testing
-------

Added unit tests the changes in the patch and tested in DevCloud.


Thanks,

Miguel Ferreira


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message