cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 18069: Fixing FindBugs scariest for replaceFirst() method call that does not assign the return value
Date Fri, 14 Feb 2014 09:12:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18069/#review34469
-----------------------------------------------------------

Ship it!


commit 8c5886ee7fadcab11834f9e514cf05925f67fc33
Author: wrodrigues <wrodrigues@schubergphilis.com>
Date:   Mon Feb 10 15:13:56 2014 +0100

    fixing FindBugs scariest for replaceFirst() method call that does not assign the return
value
    
    Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>


- Hugo Trippaers


On Feb. 13, 2014, 12:07 p.m., Wilder Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18069/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 12:07 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing FindBugs scariest for replaceFirst() method call that  does not assign the return
value
> 
> 
> Diffs
> -----
> 
>   plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
37861b4 
>   plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/provider/CloudStackPrimaryDataStoreProviderImpl.java
410416c 
> 
> Diff: https://reviews.apache.org/r/18069/diff/
> 
> 
> Testing
> -------
> 
> Build ran successfully
> 
> 
> Thanks,
> 
> Wilder Rodrigues
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message