cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request 18067: Fixed "scary bug" according to find bugs. (SBP find bugs hackaton)
Date Fri, 14 Feb 2014 09:03:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18067/#review34465
-----------------------------------------------------------

Ship it!


commit 042cc69c79a428e17a1952ac172893b0629efdd0
Author: Sander Botman <sbotman@schubergphilis.com>
Date:   Tue Feb 11 17:45:00 2014 +0100

    Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull
    
    Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>


- Hugo Trippaers


On Feb. 13, 2014, 11:38 a.m., Sander Botman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18067/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 11:38 a.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Used FindBugs to find some possible scary bugs and wrote some unit tests for them.
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xen/src/com/cloud/ha/XenServerFencer.java 5604db8 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
cf5c6d6 
>   plugins/hypervisors/xen/test/com/cloud/ha/XenServerFencerTest.java PRE-CREATION 
>   plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java
c56cc6d 
> 
> Diff: https://reviews.apache.org/r/18067/diff/
> 
> 
> Testing
> -------
> 
> Refactored some code and wrote unit tests
> 
> 
> Thanks,
> 
> Sander Botman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message